Sqlite: support adding specific error context to internal exceptions - #7514
Merged
Merged
Conversation
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Adds database-specific context to internal SQLite exceptions.
|
shrima-cf
approved these changes
Sep 25, 2026
shrima-cf
left a comment
Contributor
There was a problem hiding this comment.
LGTM, could you add some more details to the comment though.
SqliteDatabase::setErrorContext() lets the owner of a database attach an identifying string (e.g. an actor id) that is appended to the description of internal exceptions thrown for failed SQLite calls.
jtolio
force-pushed
the
jolio/sqlite-suppo-ufummb
branch
from
September 25, 2026 05:36
afb6cec to
757419a
Compare
Member
Author
Added a commit message! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SqliteDatabase::setErrorContext() lets the owner of a database attach an identifying string (e.g. an actor id) that is appended to the description of internal exceptions thrown for failed SQLite calls.