Skip to content

Sqlite: support adding specific error context to internal exceptions - #7514

Merged
jtolio merged 1 commit into
mainfrom
jolio/sqlite-suppo-ufummb
Sep 25, 2026
Merged

jtolio merged 1 commit into
mainfrom
jolio/sqlite-suppo-ufummb

Conversation

@jtolio

@jtolio jtolio commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

SqliteDatabase::setErrorContext() lets the owner of a database attach an identifying string (e.g. an actor id) that is appended to the description of internal exceptions thrown for failed SQLite calls.

@jtolio
jtolio requested review from a team as code owners September 24, 2026 20:42
Comment thread src/workerd/util/sqlite.c++ Outdated
@ask-bonk

ask-bonk Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

Adds database-specific context to internal SQLite exceptions.

  1. Medium: Posted one inline comment: VFS I/O exceptions bypass the new context path.

github run

@shrima-cf shrima-cf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add some more details to the comment though.

SqliteDatabase::setErrorContext() lets the owner of a database attach
an identifying string (e.g. an actor id) that is appended to the
description of internal exceptions thrown for failed SQLite calls.
@jtolio
jtolio force-pushed the jolio/sqlite-suppo-ufummb branch from afb6cec to 757419a Compare September 25, 2026 05:36
@jtolio

jtolio commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

LGTM, could you add some more details to the comment though.

Added a commit message!

@jtolio
jtolio enabled auto-merge September 25, 2026 13:08
@jtolio
jtolio merged commit dbc56cf into main Sep 25, 2026
30 of 35 checks passed
@jtolio
jtolio deleted the jolio/sqlite-suppo-ufummb branch September 25, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants