Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat(frontend/proposal_list): add content uploaded status #250
Conversation
coveralls
commented
May 16, 2015
|
@umulingu possible to upload a screenshot for your change here, please? |
theskumar
changed the title
| @@ -91,7 +91,7 @@ | |||
| </div> | |||
|
|
|||
| {% if proposals_to_review %} | |||
| {% include 'proposals/partials/proposal-list--items.html' with proposals=proposals_to_review title="Proposals To Be Reviewed" display_status=False %} | |||
| {% include 'proposals/partials/proposal-list--items.html' with proposals=proposals_to_review title="Proposals To Be Reviewed" display_status=False content_status=True %} | |||
This comment has been minimized.
This comment has been minimized.
theskumar
May 16, 2015
Member
This is always content_status is always going to be true, wondering why would you like to do something like this. You need implement actual logic for detecting content uploaded or not.
This comment has been minimized.
This comment has been minimized.
umulingu
May 18, 2015
Author
@theskumar
Because we have to display content status for "proposals to review" tab only.
This comment has been minimized.
This comment has been minimized.
|
Closing as this is fixed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
umulingu commentedMay 16, 2015
closes #242