Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Remove unnecessary "includes" directives #2366
Merged
Conversation
The values defined by the referenced files are not used by these tests. This makes their inclusion superfluous, which needlessly increases the time to execute the tests and may confuse some readers.
The `$DETACHBUFFER` function is the preferred mechanism for detaching array buffers. Likewise, `verifyNotWritable` is the preferred mechanism for asserting lack of writability.
leobalter
merged commit e2903e2
into
tc39:master
2 of 8 checks passed
2 of 8 checks passed
ci/circleci: Project lint and generation unit tests on Python 3
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The values defined by the referenced files are not used by these tests.
This makes their inclusion superfluous, which needlessly increases the
time to execute the tests and may confuse some readers.
Also,
Update tests to use APIs defined by included files
The
$DETACHBUFFERfunction is the preferred mechanism for detaching array buffers.Likewise,
verifyNotWritableis the preferred mechanism for asserting lack of writability.