Created on 2019-05-07 14:17 by p-ganssle, last changed 2019-08-29 12:55 by vstinner. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 14842 | merged | nanjekyejoannah, 2019-07-18 14:50 | |
| Messages (4) | |||
|---|---|---|---|
| msg341731 - (view) | Author: Paul Ganssle (p-ganssle) *  |
Date: 2019-05-07 14:17 | |
This is a child issue for bpo 36782, specifically for testing the macro-only datetime C API functions Untested macros with no corresponding API module: - PyDateTime_GET_YEAR - PyDateTime_GET_MONTH - PyDateTime_GET_DAY - PyDateTime_DATE_GET_HOUR - PyDateTime_DATE_GET_MINUTE - PyDateTime_DATE_GET_SECOND - PyDateTime_DATE_GET_MICROSECOND - PyDateTime_TIME_GET_HOUR - PyDateTime_TIME_GET_MINUTE - PyDateTime_TIME_GET_SECOND - PyDateTime_TIME_GET_MICROSECOND - PyDateTime_DELTA_GET_DAYS - PyDateTime_DELTA_GET_SECONDS - PyDateTime_DELTA_GET_MICROSECONDS For all of these, I think you can write one "wrapper function" that just extracts all fields as a tuple (4 C API wrapper functions - date, datetime, time, timedelta). For each function, test with both the standard class and a subclass. |
|||
| msg342235 - (view) | Author: Edison Abahurire (edison.abahurire) * | Date: 2019-05-12 01:54 | |
I'm now working on this as pbo-36782 awaits merging. |
|||
| msg350771 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-08-29 12:54 | |
New changeset 2c5fb1711818926862d0d7b2e5effcaa5a5eb002 by Victor Stinner (Joannah Nanjekye) in branch 'master': bpo-36833: Add tests for Datetime C API Macros (GH-14842) https://github.com/python/cpython/commit/2c5fb1711818926862d0d7b2e5effcaa5a5eb002 |
|||
| msg350772 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-08-29 12:55 | |
Thanks Joannah Nanjekye, well done ;-) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-08-29 12:55:19 | vstinner | set | status: open -> closed resolution: fixed messages: + msg350772 stage: patch review -> resolved |
| 2019-08-29 12:54:49 | vstinner | set | nosy:
+ vstinner messages: + msg350771 |
| 2019-07-18 14:50:11 | nanjekyejoannah | set | keywords:
+ patch stage: patch review pull_requests: + pull_request14633 |
| 2019-07-18 14:41:10 | nanjekyejoannah | set | nosy:
+ nanjekyejoannah versions: + Python 3.9 |
| 2019-05-12 01:54:41 | edison.abahurire | set | nosy:
+ anthony shaw messages: + msg342235 |
| 2019-05-07 14:17:31 | p-ganssle | create | |
