Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLibvirt LXC: allow to check for container existence and status #585
Conversation
agx
added a commit
to agx/serverspec
that referenced
this pull request
Oct 4, 2016
|
Please modify lib/specinfra/command/linux/base/lxc_container.rb like this. def check_exists(container)
[
"lxc-ls -1 | grep -w #{escape(container)}",
"virsh -c lxc:/// list --all --name | grep -w '^#{escape(container)}$'"
].join(' || ')
end |
|
@mizzy updated. |
|
Not needed when we handle LibvirtLXC in LXC as @mizzy suggested. |
|
Argh, i closed the wrong one. Meant to close the one on serverspec. Sorry |
|
Thanks! |
|
Released as v2.63.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is similar to LXC but libvirt-lxc containers are implemented
differently and need the libvirt tools to check existence and status.