The Wayback Machine - http://web.archive.org/web/20201010084645/https://github.com/osmandapp/OsmAnd-iOS/issues/833
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!! editing OSM POIs with OsmAnd moved them to incorrect location #833

Closed
stragu opened this issue Sep 12, 2020 · 9 comments
Closed

!! editing OSM POIs with OsmAnd moved them to incorrect location #833

stragu opened this issue Sep 12, 2020 · 9 comments
Assignees
Milestone

Comments

@stragu
Copy link

@stragu stragu commented Sep 12, 2020 •

I changed opening hours of a handful of POIs in OsmAnd 3.14, and uploaded all the changes in one go with My Places -> OSM edits.

The changeset moved the POIs to different locations: https://www.openstreetmap.org/changeset/90741096

The POIs were mostly moved in one direction, towards the east, between 20 and 40 m, but some were moved westward instead. I am not sure what the logic is there.

That is a very serious issue as it deteriorates the quality of the data without the contributor's knowledge.

To be extra clear: I did not use the "change object position" feature (I didn't even know it existed before today).

@stragu
Copy link
Author

@stragu stragu commented Sep 12, 2020

I already fixed the incorrect locations, so here is an illustration of part of what was moved (annotating the current OSM tiles that are still representative of the incorrect locations). The blue arrows show where the POIs should have stayed.

image

@vshcherb vshcherb added this to the 3.80-iOS milestone Sep 14, 2020
@vshcherb
Copy link
Member

@vshcherb vshcherb commented Sep 14, 2020

Looks like rounding error we need to double check what's going with the code. Thanks for feedback

@stragu
Copy link
Author

@stragu stragu commented Sep 14, 2020

Ah that makes sense, I can see it now:

image

For example, on the x axis, it looks like it rounded to the closest 0.001

@stragu
Copy link
Author

@stragu stragu commented Sep 14, 2020 •

Looks like it is happening to everyone using this version, I can find the issue in changesets dating back to May this year:
https://osmcha.org/?filters=%7B%22editor%22%3A%5B%7B%22label%22%3A%22osmand%20maps%203.14%22%2C%22value%22%3A%22osmand%20maps%203.14%22%7D%5D%2C%22date__gte%22%3A%5B%7B%22label%22%3A%222020-04-01%22%2C%22value%22%3A%222020-04-01%22%7D%5D%7D

OSMCha shows me close to 1000 changesets using this version of OsmAnd.

Not sure if previous versions were also affected by the same issue.

@stragu
Copy link
Author

@stragu stragu commented Sep 14, 2020

Actually, it looks like it rounds the coordinates to 6 significant figures, not a specific number of decimals. See for example this history: https://www.openstreetmap.org/node/575564098/history

  • x axis: 153.0071854 -> 153.0070000
  • y axis: -27.4805811 -> -27.4806000

Older versions are also affected.

@stragu
Copy link
Author

@stragu stragu commented Sep 15, 2020 •

Looking at OSMCha, at least the following versions of OSMAnd are affected:

  • 3.10
  • 3.11
  • 3.12
  • 3.13
  • 3.14

An example in version 3.13:

image

@nnngrach nnngrach linked a pull request that will close this issue Sep 17, 2020
@stragu
Copy link
Author

@stragu stragu commented Sep 19, 2020

Thanks for releasing that quickly in 3.80.
I'm surprised the fix didn't make it into the release notes. Don't you think there should be some communication about this issue to get people to update as soon as possible?
Or maybe in the blog post, I you write one for the 3.80 release?

@Firefishy
Copy link

@Firefishy Firefishy commented Sep 21, 2020

I'm part of the OSM ops team, should we be blocking any particular versions from accessing the API? What user-agent or other headers could we use to match the broken versions?

@vshcherb
Copy link
Member

@vshcherb vshcherb commented Sep 21, 2020

New IOS version with new User-Agent and fix is already out. The problem previous versions didn't have User-Agent specified, so this makes it tricky.
Since OsmAnd 3.80, 3.81,.... both problems are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.