Closed Bug 1273551 Opened 10 years ago Closed 2 years ago

Add the "Debug Script" option to nightly builds

Categories

(Core :: DOM: Content Processes, defect, P4)

Product:
Core
Component:
DOM: Content Processes
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
e10s + ---
firefox49 --- wontfix
firefox126 --- fixed

People

(Reporter: jujjyl, Assigned: mfoulks1)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1273551 - Enabled 'Debug Script' button in nightly builds as well as the dev edition
48 bytes, text/x-phabricator-request
Details | Review
When running page that runs into an infinite loop, in non-e10s mode there are the options "Continue", "Debug Script" and "Stop Script". However when running under e10s, the slow script dialog banner only shows options "Stop It" and "Wait". Is there a reason why the "Debug Script" option is no longer available? It is sometimes useful.
This should be available on dev edition.
Just confirmed, this is visible on aurora.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
Sorry, I wasn't precise, this was tested on Nightly. Shouldn't Nightly always have the latest features? How come we have a feature in Dev Edition we don't have in Nightly? If the feature is in aurora but isn't in Nightly, doesn't that mean that the feature has regressed?
Flags: needinfo?(jmathies)
(In reply to Jukka Jylänki from comment #3) > Sorry, I wasn't precise, this was tested on Nightly. Shouldn't Nightly > always have the latest features? How come we have a feature in Dev Edition > we don't have in Nightly? If the feature is in aurora but isn't in Nightly, > doesn't that mean that the feature has regressed? This was a casual decision made when we put the new ui together. We can open this and morph it into adding the debug option in nightly builds, which would be pretty easy to do. Woudl you like to take a shot at fixing this?
Status: RESOLVED → REOPENED
tracking-e10s: --- → +
Flags: needinfo?(jmathies)
Priority: -- → P4
Resolution: WORKSFORME → ---
Summary: Migrating to e10s, the slow script dialog has lost the "Debug Script" option. → Add the "Debug Script" option to nightly builds
Whiteboard: [good first bug]
Hi Guys, Would like to work on this bug. Can someone tell me in a little detail what needs to be done?
Flags: needinfo?(jujjyl)
Keywords: good-first-bug
Whiteboard: [good first bug]

Clearing needinfo on old bugs - I am no longer working on Mozilla. Not sure if this was ever resolved.

Flags: needinfo?(jujjyl)
Severity: normal → S3
Assignee: nobody → mfoulks1

Hello!

This is my first PR with FF/Mozilla, so go easy on me. I tried to look for the easiest beginner issue, just to get my feet wet, and it seemed like all that needed to happen here was to make the Debug Script button show up on a tab hang in Nightly as well as developer mode. Since that constant is already exposed, it's just a one-liner patch. Let me know if I misinterpreted the issue, or missed something in the implementation that needs to be changed.

Hopefully I can start tackling some issues with some complexity next :P

Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/059192553e9b Enabled 'Debug Script' button in nightly builds as well as the dev edition r=jdescottes

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Assignee: mfoulks1 → nobody
Status: REOPENED → NEW

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.

Flags: needinfo?(mfoulks1)

Sorry I missed this at the time, but it just looks like this one line in the test that failed needs to be adjusted to also return 2 if AppConstants.NIGHTLY_BUILD is true.

Assignee: nobody → mfoulks1
Attachment #9354007 - Attachment description: Bug 1273551 - Enabled 'Debug Script' button in nightly builds as well as the dev edition r=Standard8 → Bug 1273551 - Enabled 'Debug Script' button in nightly builds as well as the dev edition
Status: NEW → ASSIGNED

I fixed the test and I've attempted to reland.

Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6071829fc75 Enabled 'Debug Script' button in nightly builds as well as the dev edition r=jdescottes

https://hg.mozilla.org/mozilla-central/rev/e6071829fc75

Status: ASSIGNED → RESOLVED
Closed: 10 years ago → 2 years ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: