Skip to content

Commit 9985d78

Browse files
committed
Revert "gorhill#12"
This reverts commit 547a6c0.
1 parent 547a6c0 commit 9985d78

5 files changed

Lines changed: 9 additions & 32 deletions

File tree

‎platform/chromium/options_ui.html‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
<meta charset="utf-8">
55
<script src="js/vapi.js"></script>
66
<script src="js/vapi-client.js"></script>
7-
<!-- Patch 2017-12-09: Properly fix dashboard opening handling -->
8-
<script src="js/vapi-nano.js"></script>
97
<script src="js/options_ui.js"></script>
108
<title></title>
119
</head>

‎platform/chromium/vapi-client.js‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -433,6 +433,15 @@ vAPI.messaging.Connection.prototype = {
433433

434434
/******************************************************************************/
435435

436+
// Patch 2017-12-06: Replace the current tab
437+
vAPI.openHere = function(path) {
438+
if ( chrome.tabs !== undefined ) {
439+
chrome.tabs.update({ url: path });
440+
}
441+
};
442+
443+
/******************************************************************************/
444+
436445
vAPI.shutdown.add(function() {
437446
vAPI.messaging.shutdown();
438447
window.vAPI = undefined;

‎platform/chromium/vapi-nano.js‎

Lines changed: 0 additions & 21 deletions
This file was deleted.

‎src/dashboard.html‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@
2626

2727
<script src="js/vapi.js"></script>
2828
<script src="js/vapi-common.js"></script>
29-
<!-- Patch 2017-12-09: Properly fix dashboard opening handling -->
30-
<script src="js/vapi-nano.js"></script>
3129
<script src="js/udom.js"></script>
3230
<script src="js/i18n.js"></script>
3331
<script src="js/dashboard.js"></script>

‎src/js/dashboard.js‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,4 @@ uDom.onLoad(function() {
8080

8181
/******************************************************************************/
8282

83-
// Patch 2017-12-09: Make back button properly return to extension manager
84-
window.addEventListener('beforeunload', function() {
85-
vAPI.openHere(vAPI.extensionManager);
86-
});
87-
88-
/******************************************************************************/
89-
9083
})();

0 commit comments

Comments
 (0)