Skip to content

Commit d945a68

Browse files
authored
fix: remove the edge when the node is deleted in dag exporter (pinterest#1089)
1 parent 0ab0d6d commit d945a68

15 files changed

Lines changed: 106 additions & 53 deletions

File tree

‎package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "querybook",
3-
"version": "3.14.0",
3+
"version": "3.14.1",
44
"description": "A Big Data Webapp",
55
"private": true,
66
"scripts": {
@@ -79,7 +79,6 @@
7979
"react-dnd": "^15.1.2",
8080
"react-dnd-html5-backend": "^15.1.2",
8181
"react-dom": "17.0.2",
82-
"react-flow-renderer": "^10.3.17",
8382
"react-hot-toast": "^2.0.0",
8483
"react-json-view": "^1.21.3",
8584
"react-lazyload": "^3.2.0",
@@ -88,6 +87,7 @@
8887
"react-select": "4.3.1",
8988
"react-table": "6.8.6",
9089
"react-virtualized": "9.22.3",
90+
"reactflow": "^11.3.0",
9191
"reactour": "^1.18.6",
9292
"redux": "4.1.0",
9393
"redux-logger": "3.0.6",

‎querybook/webapp/components/DataDocDAGExporter/DataDocDAGExporterGraph.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as React from 'react';
22
import { ConnectDropTarget } from 'react-dnd';
3-
import { Edge, Node, ReactFlowInstance } from 'react-flow-renderer';
3+
import { Edge, Node, ReactFlowInstance } from 'reactflow';
44

55
import { QueryDAGNodeTypes } from 'hooks/dag/useExporterDAG';
66
import { FlowGraph } from 'ui/FlowGraph/FlowGraph';

‎querybook/webapp/components/DataTableViewLineage/DataTableViewLineage.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react';
2-
import { Edge, Node } from 'react-flow-renderer';
2+
import { Edge, Node } from 'reactflow';
33

44
import { DataTableViewMini } from 'components/DataTableViewMini/DataTableViewMini';
55
import { IDataTable, ILineage, ILineageCollection } from 'const/metastore';

‎querybook/webapp/const/datadoc.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { ContentState } from 'draft-js';
2-
import { Edge, Node } from 'react-flow-renderer';
2+
import { Edge, Node } from 'reactflow';
33

44
import { IChartConfig } from './dataDocChart';
55

‎querybook/webapp/hooks/dag/useExporterDAG.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import {
66
useState,
77
} from 'react';
88
import { useDrop } from 'react-dnd';
9-
import { Edge, Node, Position, ReactFlowInstance } from 'react-flow-renderer';
109
import { useSelector } from 'react-redux';
10+
import { Edge, Node, Position, ReactFlowInstance } from 'reactflow';
1111

1212
import { queryCellDraggableType } from 'components/DataDocDAGExporter/DataDocDAGExporter';
1313
import { IDataQueryCell } from 'const/datadoc';

‎querybook/webapp/hooks/dag/useSavedDAG.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react';
2-
import { Edge, Node } from 'react-flow-renderer';
32
import { useDispatch, useSelector } from 'react-redux';
3+
import { Edge, Node } from 'reactflow';
44

55
import { hashString } from 'lib/data-doc/data-doc-utils';
66
import { fetchDAGExport, saveDAGExport } from 'redux/dataDoc/action';

‎querybook/webapp/redux/dataDoc/action.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { ContentState, convertToRaw } from 'draft-js';
22
import { mapValues } from 'lodash';
33
import moment from 'moment';
44
import { normalize, schema } from 'normalizr';
5-
import { Edge, Node } from 'react-flow-renderer';
5+
import { Edge, Node } from 'reactflow';
66

77
import { IAccessRequest } from 'const/accessRequest';
88
import {

‎querybook/webapp/resource/dataDoc.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Edge, Node } from 'react-flow-renderer';
1+
import { Edge, Node } from 'reactflow';
22

33
import { IAccessRequest } from 'const/accessRequest';
44
import type {

‎querybook/webapp/ui/FlowGraph/FlowGraph.tsx‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ import ReactFlow, {
1616
ReactFlowInstance,
1717
ReactFlowProvider,
1818
useReactFlow,
19-
} from 'react-flow-renderer';
19+
} from 'reactflow';
20+
21+
import 'reactflow/dist/style.css';
2022

2123
import { GraphControls } from './GraphControls';
2224
import {

‎querybook/webapp/ui/FlowGraph/GraphControls.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
useReactFlow,
66
useStore,
77
useStoreApi,
8-
} from 'react-flow-renderer';
8+
} from 'reactflow';
99

1010
import { IconButton } from 'ui/Button/IconButton';
1111

0 commit comments

Comments
 (0)