Page MenuHomePhabricator
Create Task
Maniphest T314609

Make ApiFunctionCallTest Compare Errors
Open, LowPublic
Actions

Description

ApiFunctionCallTest does not currently check that the correct error was raised. This is currently relevant in one test.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add orchestratorHttpStatusCode to the ApiFunctionCall payloadGenoveva Galarzamediawiki/extensions/WikiLambdamaster+314 -90
Customize query in gerrit

Event Timeline

cmassaro created this task.Aug 4 2022, 7:46 PM
DVrandecic moved this task from To Triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Aug 16 2022, 6:37 PM
DVrandecic edited projects, added: Abstract Wikipedia team (Phase κ – Clean-up); removed: Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:29 PM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:44 PM
Jdforrester-WMF edited projects, added: Abstract Wikipedia team; removed: Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF added projects: function-orchestrator, Abstract Wikipedia Fix-It tasks.Aug 4 2023, 11:37 AM
Jdforrester-WMF subscribed.

Note that with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/945759 we're disabling this for now, as following https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/commit/2daca7aae2846f56f7ad3952ba0a20c2964af278 and https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/commit/7986b346b91e4c09640476bf5eee780ebfd3b30a even though it does nothing it now also fails. :-)

Jdforrester-WMF triaged this task as Low priority.Apr 9 2024, 7:19 PM
Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.Apr 11 2024, 4:51 PM
Jdforrester-WMF moved this task from Backlog to Engineering Backlog on the Abstract Wikipedia team board.Dec 11 2024, 8:18 PM
gengh claimed this task.Jul 16 2026, 5:40 PM
gerritbot added a comment.Jul 17 2026, 10:53 AM

Change #1311822 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add orchestratorHttpStatusCode to the ApiFunctionCall payload

https://gerrit.wikimedia.org/r/1311822

gerritbot added a project: Patch-For-Review.Jul 17 2026, 10:53 AM
gerritbot added a comment.Jul 19 2026, 4:49 PM

Change #1311822 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add orchestratorHttpStatusCode to the ApiFunctionCall payload

https://gerrit.wikimedia.org/r/1311822

Jdforrester-WMF added a comment.Jul 19 2026, 4:53 PM

Now partially done, but still:

tests/phpunit/integration/PublicAPI/PublicApiRunTest.php
62:	// TODO (T314609): Also test error cases.
107:	// TODO (T314609): Also test that metadata has correct keys.

tests/phpunit/integration/ActionAPI/ApiFunctionCallTest.php
231:	// TODO (T314609): Also test that metadata has correct keys.
284:	// (T314609) Orchestrator error cases
Maintenance_bot removed a project: Patch-For-Review.Jul 19 2026, 5:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits