Page MenuHomePhabricator
Create Task
Maniphest T422565

Add button and keyboard shortcut to sort lines of text
Closed, ResolvedPublic
Actions

Description

Requested on Discord.

Many IDEs offer a "sort lines" option, and CodeMirror could, too. At minimum we could add a keyboard shortcut, or maybe two – one for ascending, then the other using Shift to sort descending. Additionally we could add a button to WikiEditor in the "Advanced" section, perhaps as part of the "Format" group of buttons.

Sorting should be done using localeCompare with "base" sensitivity, so that accents and capitalization are taken into account. If a particular language or wiki needs further customization, we can offer it either as a gadget or directly in CodeMirror, depending on how widespread the needs are.

Details

Other Assignee
Manvikesarwani09
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add svgo@4.0.2 and update icons with pretty format and tabsMusikAnimalmediawiki/extensions/CodeMirrormaster+152 -36
CodeMirrorWikiEditor: add icons for sort asc/descMusikAnimalmediawiki/extensions/CodeMirrormaster+31 -4
CodeMirrorSortLines: keep lines selected after sortingMusikAnimalmediawiki/extensions/CodeMirrormaster+41 -7
Add line sorting actions for CodeMirror and WikiEditorManvi Kesarwanimediawiki/extensions/CodeMirrormaster+381 -13
Add sort lines feature for CodeMirror 6 in WikiEditorManvi Kesarwanimediawiki/extensions/CodeMirrormaster+262 -1
Customize query in gerrit

Related Objects

Event Timeline

MusikAnimal created this task.Apr 8 2026, 12:51 AM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptApr 8 2026, 12:51 AM
MusikAnimal moved this task from Backlog to Feature requests on the MediaWiki-extensions-CodeMirror board.Apr 8 2026, 12:51 AM
Manvikesarwani09 subscribed.Apr 8 2026, 5:23 AM
gerritbot added a comment.Apr 8 2026, 12:59 PM

Change #1268944 had a related patch set uploaded (by Manvi Kesarwani; author: Manvi Kesarwani):

[mediawiki/extensions/CodeMirror@master] Add sort lines feature for CodeMirror 6 in WikiEditor

https://gerrit.wikimedia.org/r/1268944

gerritbot added a project: Patch-For-Review.Apr 8 2026, 12:59 PM
Manvikesarwani09 added a comment.Apr 8 2026, 1:01 PM

i have uploaded a patchset for this task can you review it

• Aklapper added a comment.Apr 8 2026, 1:15 PM

@Manvikesarwani09: Thanks; please don't duplicate a patch notification two minutes after that patch notification.

Bhsd assigned this task to Manvikesarwani09.Apr 8 2026, 2:03 PM
gerritbot added a comment.Apr 13 2026, 4:59 PM

Change #1268944 had a related patch set uploaded (by Manvi Kesarwani; author: Manvi Kesarwani):

[mediawiki/extensions/CodeMirror@master] Add sort lines feature for CodeMirror 6 in WikiEditor

https://gerrit.wikimedia.org/r/1268944

gerritbot added a comment.Apr 15 2026, 5:11 PM

Change #1271822 had a related patch set uploaded (by Manvi Kesarwani; author: Manvi Kesarwani):

[mediawiki/extensions/CodeMirror@master] Add line sorting actions for CodeMirror and WikiEditor

https://gerrit.wikimedia.org/r/1271822

gerritbot added a comment.Apr 15 2026, 5:14 PM

Change #1268944 abandoned by Manvi Kesarwani:

[mediawiki/extensions/CodeMirror@master] Add sort lines feature for CodeMirror 6 in WikiEditor

Reason:

abondon

https://gerrit.wikimedia.org/r/1268944

Manvikesarwani09 added a comment.Apr 15 2026, 5:15 PM

please review this new patchset of mine.

Bhsd subscribed.Apr 15 2026, 5:24 PM

There will be some breaking changes to be deployed next week for T373720: Deprecate use of CodeMirror 5, so I had better review new feature proposals after that.

Mr._Starfleet_Command subscribed.Apr 15 2026, 8:23 PM
gerritbot added a comment.Jun 25 2026, 10:33 AM

Change #1271822 abandoned by Manvi Kesarwani:

[mediawiki/extensions/CodeMirror@master] Add line sorting actions for CodeMirror and WikiEditor

Reason:

abondon

https://gerrit.wikimedia.org/r/1271822

Bhsd removed a project: Patch-For-Review.Jul 5 2026, 11:26 AM
gerritbot added a comment.Jul 18 2026, 9:50 AM

Change #1271822 restored by MusikAnimal:

[mediawiki/extensions/CodeMirror@master] Add line sorting actions for CodeMirror and WikiEditor

https://gerrit.wikimedia.org/r/1271822

gerritbot added a project: Patch-For-Review.Jul 18 2026, 9:50 AM
gerritbot added a comment.Jul 20 2026, 5:51 PM

Change #1271822 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Add line sorting actions for CodeMirror and WikiEditor

https://gerrit.wikimedia.org/r/1271822

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.12; 2026-07-21).Jul 20 2026, 6:00 PM
Bhsd added a comment.EditedJul 30 2026, 1:19 AM

The selection becomes very strange after sorting if the original selection was not whole lines, and there is a RangeError thrown in the console.

MusikAnimal added a comment.Jul 30 2026, 1:24 AM
In T422565#12169818, @Bhsd wrote:

The selection becomes very strange after sorting if the original selection was not whole lines, and there is a RangeError thrown in the console.

I think you mean when you don't select from the start of the line, yeah? Indeed that doesn't cause weirdness… I will try to fix it.

Bhsd reassigned this task from Manvikesarwani09 to MusikAnimal.Jul 30 2026, 8:03 AM
Bhsd updated Other Assignee, added: Manvikesarwani09.
gerritbot added a comment.Aug 7 2026, 12:54 AM

Change #1322248 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirrorSortLines: keep lines selected after sorting

https://gerrit.wikimedia.org/r/1322248

MusikAnimal changed the task status from Open to In Progress.Aug 7 2026, 12:54 AM
gerritbot added a comment.Aug 7 2026, 2:31 AM

Change #1322276 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirrorWikiEditor: add custom icons for sort asc/desc; add RTL support

https://gerrit.wikimedia.org/r/1322276

gerritbot added a comment.Aug 7 2026, 2:52 AM

Change #1322284 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] Add svgo@4.0.2 and update icons with pretty format and tabs

https://gerrit.wikimedia.org/r/1322284

gerritbot added a comment.Aug 9 2026, 7:58 PM

Change #1322248 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorSortLines: keep lines selected after sorting

https://gerrit.wikimedia.org/r/1322248

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.15; 2026-08-11); removed: MW-1.47-notes (1.47.0-wmf.12; 2026-07-21).Aug 9 2026, 8:01 PM
gerritbot added a comment.Aug 13 2026, 10:27 PM

Change #1322276 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorWikiEditor: add icons for sort asc/desc

https://gerrit.wikimedia.org/r/1322276

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.16; 2026-08-18); removed: MW-1.47-notes (1.47.0-wmf.15; 2026-08-11).Aug 13 2026, 11:00 PM
gerritbot added a comment.Aug 14 2026, 6:43 AM

Change #1322284 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Add svgo@4.0.2 and update icons with pretty format and tabs

https://gerrit.wikimedia.org/r/1322284

MusikAnimal closed this task as Resolved.Aug 14 2026, 7:26 AM
MusikAnimal moved this task from Feature requests to Done on the MediaWiki-extensions-CodeMirror board.
Manvikesarwani09 added a project: RoadToWiki.Fri, Oct 9, 3:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits