Page MenuHomePhabricator
Create Task
Maniphest T430119

Unexpected textarea left padding when editing code pages
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Enable WikiEditor 2010
  • Disable CodeMirror
  • Edit any code pages (JS/CSS/JSON/Lua etc.)

What happens?:

The textarea has a large left padding.

What should have happened instead?:

The textarea should only have a small padding.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

The padding was added to prevent CodeMirror-related FOUC, but it should only be applied to users with CodeMirror enabled.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Hooks: load style module only if CodeMirror is enabledBhsdmediawiki/extensions/CodeMirrormaster+33 -9
Fix: Unexpected textarea left padding when editing code pagesNeelima25mediawiki/extensions/CodeMirrormaster+3 -3
Customize query in gerrit

Event Timeline

Bhsd created this task.Jun 25 2026, 8:10 AM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptJun 25 2026, 8:10 AM
Bhsd moved this task from Backlog to Bugs on the MediaWiki-extensions-CodeMirror board.Jun 25 2026, 8:11 AM
Bhsd added a project: Regression.

Tagging Regression because it only happens after this week's deployment.

Mr._Starfleet_Command subscribed.Jun 26 2026, 6:24 AM
Prashant32194 subscribed.Jul 10 2026, 6:42 AM
Neelimaa1 claimed this task.Jul 10 2026, 6:45 AM
Neelimaa1 subscribed.
gerritbot added a comment.Jul 10 2026, 7:29 AM

Change #1309553 had a related patch set uploaded (by Neelima25; author: Neelima25):

[mediawiki/extensions/CodeMirror@master] Fix: Unexpected textarea left padding when editing code pages

https://gerrit.wikimedia.org/r/1309553

gerritbot added a project: Patch-For-Review.Jul 10 2026, 7:29 AM
Neelimaa1 added a project: RoadToWiki.Jul 10 2026, 7:31 AM
Bhsd added a subscriber: MusikAnimal.Jul 12 2026, 5:03 PM

Hi @MusikAnimal, this regression is caused by this patchset in response to this comment. May I know your thoughts?

MusikAnimal added a comment.Jul 16 2026, 7:51 PM

Sorry for the delayed response. I've been quite busy, but will resume focus on CodeMirror starting this weekend. This doesn't seem like an urgent issue but I will get it fixed (unless Neelimaa1 beats me to it :)

gerritbot added a comment.Jul 17 2026, 5:03 AM

Change #1311605 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] Hooks: load style module only if CodeMirror is enabled

https://gerrit.wikimedia.org/r/1311605

Bhsd added a comment.Jul 17 2026, 5:03 AM
In T430119#12130002, @MusikAnimal wrote:

This doesn't seem like an urgent issue but I will get it fixed (unless Neelimaa1 beats me to it :)

Or I can make a patch for it.

gerritbot added a comment.Jul 18 2026, 9:55 AM

Change #1309553 abandoned by MusikAnimal:

[mediawiki/extensions/CodeMirror@master] Fix: Unexpected textarea left padding when editing code pages

Reason:

superseded by If19386da26. Thank you nonetheless for your contributions!

https://gerrit.wikimedia.org/r/1309553

gerritbot added a comment.Jul 18 2026, 9:57 AM

Change #1311605 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Hooks: load style module only if CodeMirror is enabled

https://gerrit.wikimedia.org/r/1311605

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.12; 2026-07-21).Jul 18 2026, 10:00 AM
Bhsd closed this task as Resolved.Jul 18 2026, 10:01 AM
Bhsd claimed this task.
Bhsd moved this task from Bugs to Done on the MediaWiki-extensions-CodeMirror board.
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2026, 10:31 AM
happy5214 moved this task from Backlog to Closed on the WikiEditor (2010) board.Sep 16 2026, 4:07 PM
Chuiimuii_ofc moved this task from Incoming to Completed on the RoadToWiki board.Sep 18 2026, 8:02 PM
Chuiimuii_ofc subscribed.

RoadToWiki board hygiene: moved this task to Completed so the board matches Phabricator status (resolved/closed). No change to task status or assignee.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits