The Wayback Machine - https://web.archive.org/web/20200704180253/https://github.com/github/VisualStudio/pull/2127
Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include octokit.graphql.net as a submodule. #2127

Merged
merged 1 commit into from Dec 12, 2018
Merged

Include octokit.graphql.net as a submodule. #2127

merged 1 commit into from Dec 12, 2018

Conversation

@grokys
Copy link
Contributor

grokys commented Dec 12, 2018

This will allow easier debugging/bug fixing and also allows us to include the .pdb files in the vsix.
@grokys
Include octokit.graphql.net as a submodule.
Loading status checks…
dca3956 
This also allows us to include the `.pdb` files in the vsix.
@grokys grokys requested review from StanleyGoldman and jcansdale Dec 12, 2018
@StanleyGoldman
StanleyGoldman approved these changes Dec 12, 2018
View changes
Copy link
Contributor

StanleyGoldman left a comment

Woot!
@StanleyGoldman StanleyGoldman merged commit 62d8520 into master Dec 12, 2018
4 checks passed
4 checks passed
MSBuild Log 0 errors - 2402 warnings
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
github.VisualStudio Build #20181212.7 succeeded
Details
@StanleyGoldman StanleyGoldman deleted the refactor/octokit-graphql-submodule branch Dec 12, 2018
@meaghanlewis meaghanlewis added this to the 2.6.3 milestone Jan 3, 2019
@jcansdale jcansdale mentioned this pull request Jan 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanleyGoldman StanleyGoldman

@jcansdale jcansdale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.7.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@grokys @StanleyGoldman @meaghanlewis
You can’t perform that action at this time.