Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Remove the net40 target and other misc cleanup #1511
Merged
Conversation
|
@ethomson Once this is merged, I think we should put out another 0.25.0 preview package. |
Closed
Makes it handle being run when the project is not in a git repo.
|
One more change to make the GenerateAssemblyCommitIdsCs target handle when the project is being built from outside of a git repo, which should address #1512. |
This was referenced Nov 21, 2017
|
Appreciate you setting it up so that you could build from a release tarball/zipball. |
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR includes the following changes;
The net40 target has been removed from LibGit2Sharp, so we are now targeting .NET Standard 2.0 only. This means that our minimum supported version of the .NET Framework is now 4.6.1.
The test project is still targeting both net461 and netcoreapp2.0 so that we can test on both platforms.
Dependencies have been updated (this supersedes #1509), and I've moved the Nerdbank.GitVersioning reference into the main project file to make it easier to update properly with the NuGet tooling.
With the new version of xunit, there were a ton of warnings in the tests, so I cleaned up all of those as well.
As of the 2.0.2 .NET Core SDK that is installed with VS 2017 15.4, there's a simpler way to include PDBs in the package, so I've switched to that.
I've also updated to the version of the native binaries package that includes my changes from libgit2/libgit2sharp.nativebinaries#56.
The build/CI scripts still need some cleaning up, but I'll handle that in another PR.