The Wayback Machine - https://web.archive.org/web/20200705195048/https://github.com/github/VisualStudio/pull/2255
Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null commit author #2255

Merged
merged 6 commits into from Mar 11, 2019
Merged

Fix null commit author #2255

merged 6 commits into from Mar 11, 2019

Conversation

@michaelbayles
Copy link
Contributor

michaelbayles commented Mar 3, 2019

If the author is null for a particular commit, the entire Pull Request cannot load. This simple fix looks into the commit authorship instead
@michaelbayles
Using commit.Committer.Name
Loading status checks…
220ac7a
@michaelbayles michaelbayles force-pushed the michaelbayles:fix-null-commit-author branch from 15afbdf to 220ac7a Mar 3, 2019
@jcansdale
Merge branch 'master' into fix-null-commit-author
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6278621
@meaghanlewis meaghanlewis requested review from jcansdale and StanleyGoldman Mar 7, 2019
@meaghanlewis
Copy link
Contributor

meaghanlewis commented Mar 7, 2019

👋 @michaelbayles, thank you for your contribution! 🎉

@jcansdale @StanleyGoldman can you help review this PR please?
@StanleyGoldman
Copy link
Contributor

StanleyGoldman commented Mar 8, 2019

Hey @michaelbayles thanks for catching this.
I was looking at something completely unrelated and ran into the same bug, traced it down and realized you started on it.
@StanleyGoldman
Merge branch 'master' into fix-null-commit-author
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
054929b
@StanleyGoldman
Copy link
Contributor

StanleyGoldman commented Mar 8, 2019

Related #2276
@StanleyGoldman
Handling support of a null commit author
Verified
This commit was signed with a verified signature.
Image StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
1b4d2c8
@StanleyGoldman
Adding doc comments
Verified
This commit was signed with a verified signature.
Image StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
fb09c60
@StanleyGoldman StanleyGoldman removed their request for review Mar 8, 2019
@StanleyGoldman
Cleanup
Verified
This commit was signed with a verified signature.
Image StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
548757c
@jcansdale
jcansdale approved these changes Mar 11, 2019
View changes
Copy link
Collaborator

jcansdale left a comment

Confirmed the bug and the fix.

image

This is good to go. 👍
@StanleyGoldman StanleyGoldman merged commit 63cf8e0 into github:master Mar 11, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
github.VisualStudio Build #20190308.14 succeeded
Details
@StanleyGoldman
Copy link
Contributor

StanleyGoldman commented Mar 11, 2019

Thanks for starting this off @michaelbayles
@StanleyGoldman StanleyGoldman mentioned this pull request Mar 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcansdale jcansdale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@michaelbayles @meaghanlewis @StanleyGoldman @jcansdale
You can’t perform that action at this time.