The Wayback Machine - https://web.archive.org/web/20201215051344/https://github.com/github/VisualStudio/pull/2305
Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting host address for GitHub Enterprise connections #2305

Merged
merged 1 commit into from Mar 29, 2019
Merged

Correcting host address for GitHub Enterprise connections #2305

merged 1 commit into from Mar 29, 2019

Conversation

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Mar 28, 2019

Fixes #2224
@StanleyGoldman StanleyGoldman requested a review from jcansdale Mar 28, 2019
@StanleyGoldman
Correcting how the graphql connection is obtained
Verified
This commit was signed with a verified signature.
Image StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
fa55eff
@StanleyGoldman StanleyGoldman force-pushed the fixes/enterprise-http branch from 43157a9 to fa55eff Mar 28, 2019
@jcansdale jcansdale mentioned this pull request Mar 29, 2019
Closed
@jcansdale
jcansdale approved these changes Mar 29, 2019
View changes
Copy link
Collaborator

@jcansdale jcansdale left a comment

This fix makes sense.

I'm happy to merge once we get a 👍 from @pmunin.
@pmunin
Copy link

@pmunin pmunin commented Mar 29, 2019

👍 Just installed and tried it, comment on PRs from visual studio works now! Thanks for prompt fix! 👍
@meaghanlewis meaghanlewis merged commit 1cf7713 into master Mar 29, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
github.VisualStudio Build #20190328.14 succeeded
Details
@meaghanlewis meaghanlewis deleted the fixes/enterprise-http branch Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcansdale jcansdale

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@StanleyGoldman @pmunin @jcansdale @meaghanlewis
You can’t perform that action at this time.