-
Notifications
You must be signed in to change notification settings - Fork 756
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: cloudflare/workerd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.20260926.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: cloudflare/workerd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.20260927.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 4 commits
- 42 files changed
- 3 contributors
Commits on Sep 26, 2026
-
kj-rs: drop a KjOwn<T> through kj::Own<T>'s own destructor
Rust dropped every KjOwn<T> as a kj::Own<void>. kj::Own<T>::~Own() hands the disposer the address of the complete object (dynamic_cast<void*> for a polymorphic T); kj::Own<void> passes the T subobject's address unchanged. When T is a base at a nonzero offset of the object it points into (multiple inheritance: RequestObserverWithTracer's WorkerInterface base, kj::NullStream's AsyncOutputStream base), the object was deleted at the wrong address. The cxx bridge now generates a per-type drop, as it does for UniquePtr<T>: a C++ function running kj::Own<T>::~Own() and a Rust OwnTarget implementation calling it, for every T the bridge declares and holds in a KjOwn. A bridge that only aliases a type asks its declaring bridge for the implementation with `impl KjOwn<T> {}`. The primitive types a KjOwn may hold are implemented in kj-rs itself. The new own-test reproduces the miscomputed address with a two-base class handed to Rust as a kj::Own of its second base. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>Configuration menu - View commit details
-
Copy full SHA for 1481f44 - Browse repository at this point
Copy the full SHA 1481f44View commit details -
Make Bonk reviews reliable and context-aware
About 20% of automatic Bonk reviews hung until the 30-minute job timeout and then posted "Bonk workflow was cancelled". opencode was waiting on a permission prompt for a path outside the checkout, which nothing can answer in CI. Separately, pushes after the first review were never re-reviewed, and manual /bonk re-reviews started from scratch each time. Reliability: - Deny reads outside the checkout instead of prompting. - Give ask-bonk a 25-minute timeout, inside the job timeout, so a stuck run finishes on its own. - Rename bigbonk.yml's workflow so it no longer shares Bonk's concurrency group and replaces its pending runs. Re-reviews: - Run ask-bonk from a SHA-pinned fork (danlapid/ask-bonk@4768a8b) until Cloudflare-Studio/ask-bonk#228 lands upstream. - Review every push. Re-reviews see Bonk's previous review, its threads, and only the author's changes since then. - Keep one Bonk summary comment per PR, edited in place on every review, with findings posted inline. Bonk replies to and resolves its own threads once they are fixed or declined. - Start every review with a verdict line, and hand findings to ask-bonk instead of posting them from the model. Review quality: - Run specialist reviewers in parallel before the main review, which then acts as judge. .github/bonk/specialists/ adds workerd's own: security, memory and thread safety, API compatibility, compat flags, JSG/GC, KJ style, design simplicity and Rust-first. - Tag findings by severity. Only blocking and warning findings go inline; the rest are listed in the summary. - Raise the job timeout to 45 minutes to fit the specialists, and skip types/generated-snapshot/. Cleanup: - Use the opencode nightly (opencode_dev), and drop the version pin it overrode along with the weekly updater for that pin. - Trigger on /bonk in review summaries, fetch full history for /bonk, review drafts once they are ready, and skip Dependabot PRs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Configuration menu - View commit details
-
Copy full SHA for 1a709e5 - Browse repository at this point
Copy the full SHA 1a709e5View commit details
Commits on Sep 27, 2026
-
Tune Bonk from its first live reviews and from maintainer pushback, so that a finding reads as "oh yeah, that's right" rather than noise. - Keep the rules every review follows in one place, .github/bonk/specialists/SHARED.md: never report what CI checks (builds, lints, formatting, tests) or performance micro-costs, hold test code only to "can it pass while the code is broken, is it flaky", and mark hypothetical or follow-up issues info at most. - Turn off the built-in performance specialist, and add workerd versions of the correctness, tests and docs specialists. - Stop asking for compatibility flags where they are not needed: code behind $experimental flags, Node.js and spec conformance fixes, unobservable changes, and additive exports of import-only modules. - Tighten specialist calibration from the first reviews: copyright headers only where siblings have them, compare with kj before flagging protocol deviations, test-only unsafety capped at info, and verify design suggestions before raising them. - Drop the jokes and boilerplate from review summaries. - Correct src/rust/AGENTS.md: a C++ exception through an infallible extern "C++" shim becomes a Rust panic, not an abort. - Pin danlapid/ask-bonk@4f53fb3 (Cloudflare-Studio/ask-bonk#228), which fixes the pipeline issues those reviews exposed and adds SHARED.md and disabling built-in specialists. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Configuration menu - View commit details
-
Copy full SHA for 8c23e9b - Browse repository at this point
Copy the full SHA 8c23e9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d3665a - Browse repository at this point
Copy the full SHA 1d3665aView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.20260926.1...v1.20260927.1