[WO-1581] Enable span status and renaming - #7348
Merged
Merged
Conversation
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Adds user-tracing span status serialization and tail-stream exposure.
|
|
The generated output of |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7348 +/- ##
==========================================
- Coverage 38.12% 38.11% -0.02%
==========================================
Files 858 858
Lines 262589 262871 +282
Branches 24314 24383 +69
==========================================
+ Hits 100125 100205 +80
- Misses 148816 148995 +179
- Partials 13648 13671 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jmorrell-cloudflare
force-pushed
the
jmorrell/add-span-status
branch
2 times, most recently
from
September 13, 2026 22:06
fe46ea3 to
7c97753
Compare
jmorrell-cloudflare
marked this pull request as ready for review
September 13, 2026 23:08
fhanau
reviewed
Sep 16, 2026
jmorrell-cloudflare
force-pushed
the
jmorrell/add-span-status
branch
from
September 17, 2026 00:16
c45a8a3 to
fd58910
Compare
fhanau
approved these changes
Sep 17, 2026
fhanau
left a comment
Contributor
There was a problem hiding this comment.
Make sure to squash before merge.
jmorrell-cloudflare
force-pushed
the
jmorrell/add-span-status
branch
from
September 24, 2026 19:48
fd58910 to
d3719ee
Compare
…panClose`. Currently only supports updating `name` and `status` but could be expanded to other properties if there is ever a need.
```ts
type SpanStatusCode = "unset" | "ok" | "error";
interface SpanStatus {
readonly code: SpanStatusCode;
readonly message?: string;
}
type SpanUpdateInfo =
| { readonly type: "name"; readonly name: string }
| { readonly type: "status"; readonly status: SpanStatus };
interface SpanUpdate {
readonly type: "spanUpdate";
readonly info: SpanUpdateInfo;
}
```
- Extends our span model with two new methods to match OpenTelemetry:
```ts
interface TracingSpanStatus {
code: TracingSpanStatusCode;
message?: string;
}
span.updateName(name: string): this
span.setStatus(status: TracingSpanStatus): this
```
jmorrell-cloudflare
force-pushed
the
jmorrell/add-span-status
branch
from
September 24, 2026 19:57
d3719ee to
1f6faa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spanUpdateto mirrorspanOpenandspanClose. Currently only supports updatingnameandstatusbut could be expanded to other properties if there is ever a need.