Pin that a pipe waits for an erroring destination's in-flight write - #7501
Merged
Merged
Conversation
When the destination's controller errors while a write is in flight, the destination is erroring until the write settles. Backward error propagation waits for errored, so the source is not cancelled while the write is outstanding. The pipe rewrite in 04281be fixed this for the TS implementation: the old pump treated a rejected ready promise as the destination having errored. C++ also waits, then fulfills the pipe (ledger #7).
Contributor
|
LGTM |
guybedford
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the destination's controller errors while a write is in flight, the destination is erroring until the write settles. Backward error propagation waits for errored, so the source is not cancelled while the write is outstanding. The pipe rewrite in 04281be fixed this for the TS implementation: the old pump treated a rejected ready promise as the destination having errored.
C++ also waits, then fulfills the pipe (ledger #7).