Skip to content

Preserve VFS exceptions during SQLite open - #7151

Merged
jtolio merged 1 commit into
mainfrom
jolio/preserve-vfs-r2y25y
Sep 23, 2026
Merged

jtolio merged 1 commit into
mainfrom
jolio/preserve-vfs-r2y25y

Conversation

@jtolio

@jtolio jtolio commented Aug 27, 2026

Copy link
Copy Markdown
Member

Capture directory VFS exceptions raised by sqlite3_open_v2() and rethrow the original exception with its stack instead of replacing it with SQLite's generic open error.

@jtolio
jtolio requested review from a team as code owners August 27, 2026 20:21
@ask-bonk

ask-bonk Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from cf5f0bf to 76f670b Compare August 27, 2026 20:23
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 7901177 to 72111fc Compare August 27, 2026 20:23

@shrima-cf shrima-cf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 72111fc to 1c734df Compare August 28, 2026 14:11
@codecov-commenter

codecov-commenter commented Aug 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.62%. Comparing base (3a7c0c2) to head (7d9d512).

Files with missing lines Patch % Lines
src/workerd/util/sqlite-test.c++ 61.11% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7151   +/-   ##
=======================================
  Coverage   37.61%   37.62%           
=======================================
  Files         837      837           
  Lines      259634   259652   +18     
  Branches    23885    23892    +7     
=======================================
+ Hits        97661    97687   +26     
+ Misses     148645   148632   -13     
- Partials    13328    13333    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 1c734df to 2720e61 Compare August 28, 2026 15:34
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch 2 times, most recently from 701b3b2 to 86520ca Compare August 29, 2026 03:57
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch 2 times, most recently from 9186470 to 874ce3a Compare August 29, 2026 04:06
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch 2 times, most recently from bc9a0fb to a72e25a Compare August 31, 2026 15:06
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 874ce3a to d15ac5a Compare August 31, 2026 15:07
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from a72e25a to e98d7d5 Compare September 1, 2026 16:34
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from d15ac5a to 23a5297 Compare September 1, 2026 16:34
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 23a5297 to c334407 Compare September 3, 2026 03:08
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from e98d7d5 to 547449b Compare September 3, 2026 03:09
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from c334407 to 3264cda Compare September 3, 2026 21:41
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch 2 times, most recently from cecb495 to 6590202 Compare September 3, 2026 21:47
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 3264cda to dadcc4a Compare September 3, 2026 21:47
@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from 6590202 to b759788 Compare September 4, 2026 02:55
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch 2 times, most recently from 89ced09 to 658c061 Compare September 4, 2026 09:58
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch 2 times, most recently from 9f54bae to e8b56e7 Compare September 4, 2026 10:54
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch 2 times, most recently from 0b571c8 to e96b628 Compare September 4, 2026 11:19
@jtolio
jtolio force-pushed the jolio/tag-sqlite-e-3ybjsg branch from e8b56e7 to ab1bd10 Compare September 4, 2026 11:19
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from e96b628 to d11006e Compare September 4, 2026 13:00
@jtolio
jtolio changed the base branch from jolio/tag-sqlite-e-3ybjsg to jolio/move-sqlite-cftsdt September 4, 2026 13:01
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from d11006e to 7fdb6c5 Compare September 4, 2026 14:50
@jtolio
jtolio force-pushed the jolio/move-sqlite-cftsdt branch 2 times, most recently from 31e7528 to c240f0e Compare September 4, 2026 17:18
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 7fdb6c5 to ca8e4ec Compare September 4, 2026 17:18
Base automatically changed from jolio/move-sqlite-cftsdt to main September 9, 2026 02:52
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from ca8e4ec to 505cff9 Compare September 9, 2026 02:52
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch 2 times, most recently from a0761a6 to 8d36552 Compare September 22, 2026 17:01
Capture directory VFS exceptions raised by sqlite3_open_v2()
and rethrow the original exception with its stack instead of
replacing it with SQLite's generic open error.
@jtolio
jtolio force-pushed the jolio/preserve-vfs-r2y25y branch from 8d36552 to 7d9d512 Compare September 22, 2026 19:50
@jtolio
jtolio removed this pull request from stack #7247 September 22, 2026 19:50
@jtolio
jtolio merged commit 9be8b36 into main Sep 23, 2026
22 of 24 checks passed
@jtolio
jtolio deleted the jolio/preserve-vfs-r2y25y branch September 23, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants