This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[18.09 backport] Update containerd v1.2.5, runc 2b18fe1d885ee5 binaries#173
Merged
andrewhsu merged 2 commits intodocker-archive:18.09from Mar 20, 2019
Merged
Conversation
Notable Updates - Fix an issue that non-existent parent directory in image layers is created with permission 0700. containerd#3017 - Fix an issue that snapshots of the base image can be deleted by mistake, when images built on top of it are deleted. containerd#3087 - Support for GC references to content from snapshot and container objects. containerd#3080 - cgroups updated to dbea6f2bd41658b84b00417ceefa416b97 to fix issues for systemd 420 and non-existent cgroups. containerd#3079 - runc updated to 2b18fe1d885ee5083ef9f0838fee39b62d653e30 to include the improved fix for CVE-2019-5736. containerd#3082 - cri: Fix a bug that pod can't get started when the same volume is defined differently in the image and the pod spec. cri#1059 - cri: Fix a bug that causes container start failure after in-place upgrade containerd to 1.2.4+ or 1.1.6+. cri#1082 - cri updated to a92c40017473cbe0239ce180125f12669757e44f. containerd#3084 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 25cdae2) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Relevant changes: - containerd/containerd#51 Fix empty device type - containerd/containerd#52 Remove call to unitName - Calling unitName incorrectly appends -slice onto the end of the slice cgroup we are looking for - addresses containerd/containerd#47 cgroups: cgroup deleted - containerd/containerd#53 systemd-239+ no longer allows delegate slice - containerd/containerd#54 Bugfix: can't write to cpuset cgroup - containerd/containerd#63 Makes Load function more lenient on subsystems' checking - addresses containerd/containerd#58 Very strict checking of subsystems' existence while loading cgroup - containerd/containerd#67 Add functionality for retrieving all tasks of a cgroup - containerd/containerd#68 Fix net_prio typo - containerd/containerd#69 Blkio weight/leafWeight pointer value - containerd/containerd#77 Check for non-active/supported cgroups - addresses containerd/containerd#76 unable to find * in controller set: unknown - addresses docker/for-linux#545 Raspbian: Error response from daemon: unable to find "net_prio" in controller set: unknown - addresses docker/for-linux#552 Error response from daemon: unable to find "cpuacct" in controller set: unknown - addresses docker/for-linux#545 Raspbian: Error response from daemon: unable to find "net_prio" in controller set: unknown Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 386b06e) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @tonistiigi @dmcgowan PTAL |
andrewhsu
approved these changes
Mar 20, 2019
andrewhsu
left a comment
andrewhsu
left a comment
There was a problem hiding this comment.
LGTM in regards to what was chosen to be backported in this PR (plus tests are super green!)
tonistiigi
approved these changes
Mar 20, 2019
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partial backport of moby#38873 (only the first and last commit); I don't think we need the containerd client and runc vendoring, but double check if it's needed 🙏