Docker deamon doesn't work with --fixed-cidr on windows#1916
Merged
fcrisciani merged 1 commit intomoby:masterfrom Dec 8, 2017
msabansal:fixcidr
Merged
Docker deamon doesn't work with --fixed-cidr on windows#1916fcrisciani merged 1 commit intomoby:masterfrom msabansal:fixcidr
fcrisciani merged 1 commit intomoby:masterfrom
msabansal:fixcidr
Conversation
|
Please sign your commits following these rules: $ git clone -b "fixcidr" git@github.com:msabansal/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Sandeep Bansal <sabansal@microsoft.com>
Contributor
Author
|
Can we merge this? Fixes https://github.com/MicrosoftDocs/Virtualization-Documentation-Private/issues/1569 |
fcrisciani
pushed a commit
to fcrisciani/docker
that referenced
this pull request
Dec 14, 2017
Windows fixes: moby/libnetwork#1916 moby/libnetwork#2014 moby/libnetwork#2021 Fix for veth leak on daemon crash Cleanup networkDB logic for node management Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker deamon fails to start when launched with --fixed-cidr parameter on windows.
This is because we are sending an invalid gateway address. Sending a gateway address was a temporary workaround which was added to prevent the daemon from crashing and is not needed any more so removing that.