Merged
Conversation
The package updated and now shows new warnings that had to be corrected to let the CI pass Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com> (cherry picked from commit 9e5748a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @fcrisciani this is likely needed for all cherry-picks in this branch to go green 😅 |
Member
Author
|
I'll rebase the other PR's after this one has been merged 👍 |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick of #1947 for the 17.09 branch
The package updated and now shows new warnings that had to be corrected to let the CI pass