Skip to content

fix: correct warning event text format when deactivation fails#6469

Merged
wozniakjan merged 1 commit into
kedacore:mainfrom
wozniakjan:chore/fix_event_text_when_deactivation_fails
Jan 13, 2025
Merged

fix: correct warning event text format when deactivation fails#6469
wozniakjan merged 1 commit into
kedacore:mainfrom
wozniakjan:chore/fix_event_text_when_deactivation_fails

Conversation

@wozniakjan
Copy link
Copy Markdown
Member

The format message is missing two verbs (or has two extra arguments) resulting in slightly broken event text

  Warning  KEDAScaleTargetDeactivationFailed  8m14s                  keda-operator            Failed to deactivated apps/v1.Deployment default/http-server%!(EXTRA int32=1, int32=0)

Checklist

@wozniakjan wozniakjan requested a review from a team as a code owner January 8, 2025 15:48
@wozniakjan
Copy link
Copy Markdown
Member Author

wozniakjan commented Jan 8, 2025

/run-e2e internal
Update: You can check the progress here

@wozniakjan wozniakjan force-pushed the chore/fix_event_text_when_deactivation_fails branch from 48f2749 to 57e0b80 Compare January 9, 2025 07:50
@wozniakjan
Copy link
Copy Markdown
Member Author

wozniakjan commented Jan 9, 2025

/run-e2e internal
Update: You can check the progress here

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan wozniakjan force-pushed the chore/fix_event_text_when_deactivation_fails branch from 57e0b80 to 2c5fe38 Compare January 9, 2025 08:13
@wozniakjan
Copy link
Copy Markdown
Member Author

wozniakjan commented Jan 9, 2025

/run-e2e internal
Update: You can check the progress here

@wozniakjan wozniakjan enabled auto-merge (squash) January 9, 2025 09:00
@wozniakjan wozniakjan changed the title chore: fix event text when deactivation fails fix: correct warning event text format when deactivation fails Jan 9, 2025
@wozniakjan wozniakjan disabled auto-merge January 13, 2025 14:04
@wozniakjan wozniakjan merged commit cd595a1 into kedacore:main Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants