Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix travis failures #56
Merged
Conversation
Master is on 6.1 so we should add a Gemfile for 6.0
Rails 5.0 and 5.1 as well as Ruby 2.2, 2.3, and 2.4 are EOL. We can remove them. Adds 6.0 Gemfile for testing.
rails/rails#35688 deprecated calling `render file` and letting it lookup the file from anywhere. This was deprecated in 6.0 and removed in 6.1, which is why travis was failing for new PRs.
eileencodes
force-pushed the
eileencodes:fix-travis-failures
branch
from
b5c1e5c
to
951c784
These tests are now failing because of changes made in rails/rails#35688. This causes the instrumentation for `@_files` to not get run, but also don't think this should be supported since that instrumentation is for templates and now files are just rendered as files not as templates.
eileencodes
force-pushed the
eileencodes:fix-travis-failures
branch
from
951c784
to
9acf9b7
lukebooth
commented
May 5, 2020
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
eileencodes commentedApr 16, 2020