The Wayback Machine - https://web.archive.org/web/20201015011453/https://github.com/electron/electron-quick-start/pull/357
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: no need to hold on to mainWindow reference #357

Merged
merged 1 commit into from Feb 3, 2020

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Feb 3, 2020

@malept
malept approved these changes Feb 3, 2020
@malept malept merged commit 6cf4eeb into electron:master Feb 3, 2020
2 checks passed
2 checks passed
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
@nornagon nornagon deleted the nornagon:patch-1 branch Feb 3, 2020
codebytere pushed a commit to electron/electron-quick-start-typescript that referenced this pull request Jun 16, 2020
…tart' (#38)

1. updated dev dependencies

2. Content-Security-Policy added
f844bb7 :  Ref - electron/electron-quick-start@0ed07b8 & electron/electron-quick-start#334

3. no need to hold on to mainWindow reference
478f1be : Ref  -electron/electron#21957  & electron/electron-quick-start#357

4. don't listen to 'activate' until ready
3e5cfff : fixes electron/electron#23476 & Ref: electron/electron-quick-start#382 

5. fix explanation of darwin auto-quit prevention
7679354 : Ref : electron/electron#24003 &  electron/electron-quick-start#394

6. docs: update stale comment - renderer has no access to Node
8e4701c : Ref: electron/electron-quick-start@6788309 & electron/electron-quick-start#308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.