Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Unite All Logging into a Single Handler #6317
Comments
|
Any idea how to go about this? It seems unlikely that we'll be able to convince go-ethereum or libp2p to use logrus. Does their log API allow writing to some |
|
I think we can conform go-ethereum's logs to use logrus, as it just needs a defined api. However libp2p is a bit more trickier, I will have to see how it works and whether it is possible. |
|
Removing from v1 milestone. This is nice to have but low priority and not enough time to complete it. |
Background
Unite all our different loggers into a single handler.
Description
Currently we run 3 different handlers, the main one is logrus through which a large amount of our
logs are logged out. The other 2 loggers are the geth logger and ipfs logger, these 2 loggers are only activated when we want trace logging. However due to them being different loggers, having all 3 of them in a single screen is confusing and difficult to read.
To resolve this issue, we would need to unite all the relevant
libp2panddiscoveryV5logs into logrus.