The Wayback Machine - https://web.archive.org/web/20201203081916/https://github.com/jsperf/jsperf.com/issues/312
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub profile for pages and tests #312

Closed
maxbeatty opened this issue Jan 12, 2017 · 1 comment
Closed

Use GitHub profile for pages and tests #312

maxbeatty opened this issue Jan 12, 2017 · 1 comment
Labels

Comments

@maxbeatty
Copy link
Member

@maxbeatty maxbeatty commented Jan 12, 2017

Now that GitHub login is required to create a page or comment, we should prefer to use the current user's GitHub profile instead of prompting for separate details (i.e. email).

  • store GitHub id alongside pages and comments
  • fallback to old fields if GitHub id missing for old entries
  • keep spam in mind (see #232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.