Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix tests not being saved when editing an existing page. #414
Conversation
|
Hi @maxbeatty , can you merge this? |
|
@mathiasbynens will you refresh me when a test should be updated? |
|
@maxbeatty Is there anything missing stopping this from being merged? |
|
@elxa please be patient. I am waiting on Mathias to clarify when a test should be updated. That response will clarify whether this is a change we should make. I will submit a review when I have all of information I need. Thank you for your contribution, but please be patient. |
When the test’s owner edits the test while still logged in to the same session (cookie-wise). On the old jsPerf, that used to be an 8-hour window, but that’s an implementation detail. |
|
I don't believe this addresses the root cause of the referenced issue. There's no difference in the session from the first time a page is created to a later date when it is edited which causes tests to always update. A more robust change is needed but I don't fully understand it yet. |
Fixes jsperf#236 Pretty much similar to jsperf#414, but with an added test to show issue.
Fixes jsperf#236 Pretty much similar to jsperf#414, but with an added test to show issue.
Fixes jsperf#236 Pretty much similar to jsperf#414, but with an added test to show issue.
Fixes #236
Looks like ownership verification is broken. If Name aka author is set your are the owner???