The Wayback Machine - https://web.archive.org/web/20201203080830/https://github.com/jsperf/jsperf.com/pull/453
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock.json #453

Merged
merged 4 commits into from Dec 12, 2017
Merged

Update package-lock.json #453

merged 4 commits into from Dec 12, 2017

Conversation

@mathiasbynens
Copy link
Contributor

@mathiasbynens mathiasbynens commented Dec 11, 2017

No description provided.

mathiasbynens and others added 3 commits Dec 11, 2017
Max Beatty
Max Beatty
@@ -1,30 +1,28 @@
{
"name": "jsperf.com",
"version": "2.0.0",
"description": "jsPerf aims to provide an easy way to create and share test cases, comparing the performance of different JavaScript snippets by running benchmarks",
"description":
"jsPerf aims to provide an easy way to create and share test cases, comparing the performance of different JavaScript snippets by running benchmarks",

This comment has been minimized.

@maxbeatty

maxbeatty Dec 12, 2017
Member

prettier may have nabbed this :/

@@ -94,6 +92,28 @@
},
"snyk": true,
"now": {
"alias": "jsperf.com"
"alias": "jsperf.com",
"env": {

This comment has been minimized.

@maxbeatty

maxbeatty Dec 12, 2017
Member

thought this was easier to manage

This comment has been minimized.

@mathiasbynens

mathiasbynens Dec 12, 2017
Author Contributor

It totally is! Thanks

@maxbeatty
Copy link
Member

@maxbeatty maxbeatty commented Dec 12, 2017

Hijacking this branch to debug this 😈 will you try to deploy this branch to now? should have more insight into why it isn't starting up with these changes

@mathiasbynens
Copy link
Contributor Author

@mathiasbynens mathiasbynens commented Dec 12, 2017

Deploying…

@mathiasbynens
Copy link
Contributor Author

@mathiasbynens mathiasbynens commented Dec 12, 2017

> ▲ npm start
> > jsperf.com@2.0.0 start /home/nowuser/src
> > node server.js
> 171212/210547.789, [log,debug] data: registering auth strategies
> 171212/210549.577, [log,info,db] data: executed 0 migrations
> 171212/210549.598, [log,info] data: connecting to redis cache
> No open port found. Make sure 'npm start' creates an HTTP server on a port (any).
Max Beatty
@@ -15,7 +15,7 @@ exports.register = function (server, options, next) {
server.expose('set', client.set.bind(client));
server.expose('drop', client.drop.bind(client));

client.start(next);
client.start().then(next).catch(next);

This comment has been minimized.

@maxbeatty

maxbeatty Dec 12, 2017
Member

catbox client start changed to being promise-based after v7 (oops) hopefully this solves the stall when connecting to rediscover

@mathiasbynens
Copy link
Contributor Author

@mathiasbynens mathiasbynens commented Dec 12, 2017

That fixes it!

@mathiasbynens mathiasbynens merged commit 3a1b91a into master Dec 12, 2017
4 of 5 checks passed
4 of 5 checks passed
Node Security 1 vulnerability found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
hound No violations found. Woof!
security/snyk No new issues
Details
@mathiasbynens mathiasbynens deleted the package-lock branch Dec 12, 2017
maxbeatty added a commit that referenced this pull request Oct 9, 2018
* master:
  Adding X-UA-Compatible in the head (#471)
  fix: .snyk & package.json to reduce vulnerabilities (#477)
  add link to wiki (#466)
  Fix issue with bad updates causing disappearing tests (#464)
  Fix cache start (#453)
  Ensure that edited test cases can be set as synchronous/asynchronous 
(#451)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.