The Wayback Machine - https://web.archive.org/web/20201203080912/https://github.com/jsperf/jsperf.com/pull/451
Skip to content

/ jsperf.com

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that edited test cases can be set as synchronous/asynchronous. #451

Merged
merged 1 commit into from Dec 11, 2017
Merged

Ensure that edited test cases can be set as synchronous/asynchronous. #451

merged 1 commit into from Dec 11, 2017

Conversation

@bnjmnt4n
Copy link
Contributor

@bnjmnt4n bnjmnt4n commented Dec 11, 2017

Closes #412.

Not too sure if I should edit any of the tests, please let me know if you want me to do so :)
@bnjmnt4n
Ensure that edited test cases can be set as synchronous/asynchronous.
Loading status checks…
d264591 
Closes #412.
@mathiasbynens mathiasbynens requested a review from maxbeatty Dec 11, 2017
@maxbeatty
maxbeatty approved these changes Dec 11, 2017
View changes
@mathiasbynens mathiasbynens merged commit f464d6b into jsperf:master Dec 11, 2017
3 of 4 checks passed
3 of 4 checks passed
Node Security 9 vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
security/snyk No new issues
Details
@mathiasbynens
Copy link
Contributor

@mathiasbynens mathiasbynens commented Dec 11, 2017

Thanks a lot, @bnjmnt4n! Deploying now.
@mathiasbynens
Copy link
Contributor

@mathiasbynens mathiasbynens commented Dec 11, 2017

@maxbeatty I’m having issues deploying with now. Is everything working for you?

> Deploying ~/projects/jsperf.com under mathias
> Using Node.js 8.9.1 (requested: `8.x.x`)
> Ready! https://jsperfcom-dumuiyqstt.now.sh (copied to clipboard) [9s]
> Synced 1 file (334.75KB) [0ms]
> Initializing…
> Initializing…
> Building
> ▲ npm install
> ✓ Using "package-lock.json"
> ⧗ Installing 30 main dependencies…
> ✓ Installed 1226 modules [10s]
> ▲ npm start
> > jsperf.com@2.0.0 start /home/nowuser/src
> > node server.js
> No open port found. Make sure 'npm start' creates an HTTP server on a port (any).
> More details: https://err.sh/now-cli/no-open-port-found
@bnjmnt4n bnjmnt4n deleted the bnjmnt4n:fix-asynchronous-edits branch Dec 12, 2017
@maxbeatty
Copy link
Member

@maxbeatty maxbeatty commented Dec 12, 2017

starts up for me locally. can you double-check that @jsperf-loggly-token secret is set properly? there aren't any logs and that's where this startup issue should explain itself (could also just enable good-console always)
@mathiasbynens
Copy link
Contributor

@mathiasbynens mathiasbynens commented Dec 12, 2017

Nothing has changed about the now/ZEIT setup:

$ now secrets ls | grep jsperf-loggly-token
  jsperf-loggly-token      323d ago

😕
@maxbeatty maxbeatty mentioned this pull request Dec 12, 2017
Merged
maxbeatty added a commit that referenced this pull request Oct 9, 2018
@maxbeatty
Merge branch 'master' into xss-comments
Loading status checks…
05cf889 
* master:
  Adding X-UA-Compatible in the head (#471)
  fix: .snyk & package.json to reduce vulnerabilities (#477)
  add link to wiki (#466)
  Fix issue with bad updates causing disappearing tests (#464)
  Fix cache start (#453)
  Ensure that edited test cases can be set as synchronous/asynchronous 
(#451)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbeatty maxbeatty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@bnjmnt4n @mathiasbynens @maxbeatty
You can’t perform that action at this time.