Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes fish shell script configuration by properly handling the fish script file extension and correcting the shebang line. The changes ensure the fish shell script is properly excluded from bash linting and has the correct interpreter declaration.
- Adds
.fishextension to the fish script file and updates references - Corrects the shebang line from bash to fish interpreter
- Excludes the fish script from bash linting configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hk.pkl | Adds fish script to bash linting exclusions |
| e2e/shell/test_fish | Updates reference to include .fish extension |
| e2e/shell/fish_script.fish | Corrects shebang from bash to fish interpreter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| #!/usr/bin/env bash | ||
| #!/usr/bin/env fish | ||
| # shellcheck disable=SC1072,SC1065,SC1064,SC1073,SC2103 | ||
|
|
There was a problem hiding this comment.
The shellcheck disable comment is designed for bash/sh scripts, but this is now a fish script. Consider removing this comment or replacing it with fish-specific linting directives if available.
Suggested change
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.8.10 x -- echo |
18.5 ± 0.4 | 17.8 | 22.6 | 1.00 |
mise x -- echo |
18.6 ± 0.5 | 17.8 | 23.6 | 1.01 ± 0.03 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.8.10 env |
17.8 ± 0.3 | 17.2 | 19.7 | 1.00 |
mise env |
18.1 ± 0.6 | 17.2 | 22.5 | 1.02 ± 0.04 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.8.10 hook-env |
17.5 ± 0.3 | 16.8 | 18.3 | 1.00 |
mise hook-env |
17.8 ± 0.3 | 17.0 | 19.2 | 1.02 ± 0.02 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.8.10 ls |
15.9 ± 0.3 | 15.2 | 19.0 | 1.00 |
mise ls |
16.1 ± 0.4 | 15.3 | 18.7 | 1.01 ± 0.03 |
xtasks/test/perf
| Command | mise-2025.8.10 | mise | Variance |
|---|---|---|---|
| install (cached) | 163ms | ✅ 102ms | +59% |
| ls (cached) | 61ms | 62ms | -1% |
| bin-paths (cached) | 66ms | 66ms | +0% |
| task-ls (cached) | 481ms | 469ms | +2% |
✅ Performance improvement: install cached is 59%
jdx
pushed a commit
that referenced
this pull request
Aug 17, 2025
### 📦 Registry - add container-use ([aqua:dagger/container-use](https://github.com/dagger/container-use)) by [@TyceHerrman](https://github.com/TyceHerrman) in [#6029](#6029) - add prek ([aqua:j178/prek](https://github.com/j178/prek)) by [@HenryZhang-ZHY](https://github.com/HenryZhang-ZHY) in [#6023](#6023) ### 🚀 Features - **(task)** allow more #MISE comments patterns by [@risu729](https://github.com/risu729) in [#6011](#6011) ### 🐛 Bug Fixes - prevent panic with task tera errors by [@jdx](https://github.com/jdx) in [#6046](#6046) ### 📚 Documentation - **(settings)** use php as an example for `disable_default_registry` by [@risu729](https://github.com/risu729) in [#6025](#6025) - Update ide-integration.md by [@jdx](https://github.com/jdx) in [#6035](#6035) - Update ide-integration.md by [@jdx](https://github.com/jdx) in [#6040](#6040) - added openSUSE zypper install instructions by [@lfromanini](https://github.com/lfromanini) in [#6037](#6037) - update `contributing.md` for discussions by [@br3ndonland](https://github.com/br3ndonland) in [#6047](#6047) ### Chore - fix warnings by [@jdx](https://github.com/jdx) in [#6043](#6043) - remove unused permissions in registry test by [@risu729](https://github.com/risu729) in [#6044](#6044) - fix fish shell script in hk config by [@jdx](https://github.com/jdx) in [#6048](#6048) ### New Contributors - @br3ndonland made their first contribution in [#6047](#6047) - @HenryZhang-ZHY made their first contribution in [#6023](#6023) - @lfromanini made their first contribution in [#6037](#6037)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.