feat: Add MSVC asset matching on Windows#6798
Merged
Conversation
Owner
|
bugbot run |
There was a problem hiding this comment.
Bug: Test Fails on Non-Musl Builds
The test unconditionally expects the musl variant to be picked on line 588, but when the build is not musl (i.e., when cfg!(target_env = "musl") is false), the gnu variant should be preferred since the AssetPicker is initialized with target_libc="gnu" (line 179). This test will fail on non-musl builds. It should be conditional like the similar test at lines 422-428.
src/backend/asset_detector.rs#L584-L588
mise/src/backend/asset_detector.rs
Lines 584 to 588 in 70fa91b
Contributor
Author
|
Thanks for the speedy review :D |
jdx
pushed a commit
that referenced
this pull request
Oct 29, 2025
### 📦 Registry - add cpz and rmz by @sassdavid in [#6793](#6793) ### 🚀 Features - Add MSVC asset matching on Windows by @trolleyman in [#6798](#6798) ### 🐛 Bug Fixes - **(cache)** exclude http backend tarballs from autoprune by @jdx in [#6806](#6806) - **(ci)** prevent release job from running when dependencies fail by @jdx in [#6804](#6804) - **(fish)** remove --move flag from fish_add_path to prevent PATH corruption by @jdx in [#6800](#6800) - **(tasks)** support local .config/mise/conf.d/*.toml tasks by @syhol in [#6792](#6792) ### 📚 Documentation - change 'claude-code' to 'claude' in examples by @bradleybuda in [#6801](#6801) ### New Contributors - @trolleyman made their first contribution in [#6798](#6798) - @bradleybuda made their first contribution in [#6801](#6801) ## 📦 Aqua Registry Updates #### New Packages (2) - [`jreisinger/checkip`](https://github.com/jreisinger/checkip) - [`suzuki-shunsuke/ghaperf`](https://github.com/suzuki-shunsuke/ghaperf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6726
Adds MSVC asset detection, and modifies the matcher to prefer it for Windows builds
Note
Adds MSVC libc detection and preference for Windows asset selection, updates docs to mention MSVC, expands tests, and improves an aqua error message.
MsvctoAssetLibcwith matching regex; detect libc for Windows as well as Linux.AssetPickernow sets target libc tomsvcon Windows and scores libc on Windows; prefers MSVC over GNU.docs/dev-tools/backends/{github,gitlab}.mdto include MSVC in libc autodetection.docs/dev-tools/backends/ubi.mdmatchingoption to mention "msvc".Written by Cursor Bugbot for commit 70fa91b. This will update automatically on new commits. Configure here.