Resolves #1270: Ensuring thread safety when creating VersionsHelper#1273
Merged
andrzejj0 merged 1 commit intomojohaus:masterfrom Sep 20, 2025
Merged
Resolves #1270: Ensuring thread safety when creating VersionsHelper#1273andrzejj0 merged 1 commit intomojohaus:masterfrom
andrzejj0 merged 1 commit intomojohaus:masterfrom
Conversation
andrzejj0
changed the title
slawekjaranowski
approved these changes
Sep 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring jobs in 2.19.0 caused a race condition when creating VersionHelper and its companion RuleServiceBuilder. In some cases, this will cause a race condition when attempting the rules file retrieval (multiple threads per dependencies will create a new VersionHelper and a new RulesServiceBuilder). "Oopsie woopsie" indeed.
@slawekjaranowski please review. Thanks.
Maybe a 2.19.1 is needed.