xDnsServerADZone: Removed CimSession from Get-TargetResource return value (Fixes #40)#49
Merged
Conversation
|
@BernieWhite, |
BernieWhite
changed the title
Contributor
Author
|
Existing readme.md fails tests. Fixed tabs with space indents. |
BernieWhite
changed the title
Contributor
Author
|
@kwirkykat Any thoughts Katie? |
kwirkykat
approved these changes
Aug 9, 2017
johlju
pushed a commit
that referenced
this pull request
Apr 20, 2018
- Fixed all PSSA rule warnings. - Changes to xDnsServerADZone - Fixed bug introduced by issue #49. Previously, CimSessions were always used regardless of connecting to a remote machine or the local machine. Now CimSessions are only utilized when a ComputerName, or ComputerName and Credential are used (issue #53).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #40
Added fix, updated unreleased changes and added unit test.
When checking other resources such as xDnsServerPrimaryZone and xDnsServerSecondaryZone they also did not return a CimSession key. I have removed CimSession from the return of Get-TargetResource within xDnsServerADZone for consistency.
This change is