Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DataDog/dd-trace-py
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.16.0
Choose a base ref
...
head repository: DataDog/dd-trace-py
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.16.2
Choose a head ref
  • 13 commits
  • 28 files changed
  • 9 contributors

Commits on Oct 14, 2025

  1. ci: make new testrunner that uses Python 3.14 [backport 3.16] (#14848)

    Backport of adc7896 from #14802 to
    3.16.
    
    Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
    vitor-de-araujo and emmettbutler authored Oct 14, 2025
    Configuration menu
    Copy the full SHA
    a8902d6 View commit details
    Browse the repository at this point in the history
  2. fix(ci_visibility): do not use is_user_code [backport 3.16] (#14836)

    Backport 7cd4d9c from #14794 to 3.16.
    
    ## Description
    
    Currently, in Test Impact Analysis code coverage, we use
    `is_user_code()` to decide whether to instrument a module. This function
    was conceived for use in non-CI contexts where user code may be
    installed in site-packages like external dependencies. This is not
    necessary in Test Optimization, where we only want to cover code inside
    the current repo (TIA only works with filenames that are relative to the
    repo root, and we already set the repo root as the include path of
    `ModuleCodeCollector`). Removing this check also resolves a bug where
    test packages are incorrectly detected as third-party if a third-party
    package contains files under `test/*` or `tests/*` that get installed at
    site-packages level (`sumy` and `sendgrid` do this, for instance).
    
    ## Testing
    
    Unit tests + manual testing in dogweb.
    
    ## Risks
    
    Potentially covering more code than expected. Should not be an issue
    because we already exclude site-packages and similar
    [here](https://github.com/DataDog/dd-trace-py/blob/vitor-de-araujo%2FSDTEST-2747%2Fcoverage-third-party/ddtrace/internal/coverage/code.py#L53).
    
    ## Additional Notes
    
    None.
    vitor-de-araujo authored Oct 14, 2025
    Configuration menu
    Copy the full SHA
    cbc429c View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2025

  1. chore(ci): fix version for system tests (#14887)

    - fix version computation for backports on 3.16
    - update ST version to fix a problem related to changes in the agent.
    christophe-papazian authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    873a407 View commit details
    Browse the repository at this point in the history
  2. fix: cleanup_loaded_modules: dont clean up modules that have not fini…

    …shed loading [backport 3.16] (#14840) (#14906)
    juanjux authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    5aa488a View commit details
    Browse the repository at this point in the history
  3. fix(AAP): reverting usage of json helper function from libddwaf [back…

    …port 3.16] (#14886)
    
    Backport 8235d03 from #14876 to 3.16.
    
    ## Description
    
    Reverting usage of json helper function from libddwaf due to some
    possibly related memory corruption errors.
    
    This is a (only partial) revert of
    #14215
    
    Also:
    - improve a test file to ensure the waf is creating a proper handle from
    this file.
    
    Co-authored-by: Christophe Papazian <114495376+christophe-papazian@users.noreply.github.com>
    dd-octo-sts[bot] and christophe-papazian authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    792d493 View commit details
    Browse the repository at this point in the history
  4. fix(ray): runtime_env can be None leading to a job error [backport 3.…

    …16] (#14903)
    
    Backport f11c438 from #14837 to 3.16.
    
    When submitting a job, `runtime_env` could be none in `kwargs`, leading
    to an `AttributeError`, see this
    [link](https://dd.datad0g.com/llm/distributed-ai/jobs?query=%40component%3Aray%20parent_id%3A0%20job-113464b6-33d0-47&agg_m=count&agg_m_source=base&agg_t=count&colorLegendSort=time&fromUser=false&spanId=5240087393744960581&traceId=68e818d800000000e5341ed29f2823d9&start=1759437349664&end=1760042149664&paused=false).
    
    This PR fixes this issue. It also updates two snapshots that were
    missing a span. The tests were xfailing so this was not caught in CI.
    
    Co-authored-by: Louis Tricot <75956635+dubloom@users.noreply.github.com>
    dd-octo-sts[bot] and dubloom authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    c680137 View commit details
    Browse the repository at this point in the history
  5. fix(ray): long running spans have now the right resource name [backpo…

    …rt 3.16] (#14904)
    
    Backport 109a976 from #14818 to 3.16.
    
    Long running spans were appearing with the operation name as the span
    name making the trace hard to interpret until the job finished.
    
    This PR adds the resource name to partial flush of long running spans
    
    Co-authored-by: Louis Tricot <75956635+dubloom@users.noreply.github.com>
    dd-octo-sts[bot] and dubloom authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    09a1427 View commit details
    Browse the repository at this point in the history
  6. fix(ray): job long running span could be never finished [backport 3.1…

    …6] (#14902)
    
    Backport a75ed3e from #14871 to 3.16.
    
    If a job was failing during job_submission, the long_running_job span
    was not finished causing the span to not leave driveline and creating
    inconsistent behavior on the UI.
    
    Co-authored-by: Louis Tricot <75956635+dubloom@users.noreply.github.com>
    dd-octo-sts[bot] and dubloom authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    2f26328 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2025

  1. ci: remove unnused action secrets from system-tests [backport 3.16] (#…

    …14839)
    
    Backport b6d846e from #14834 to 3.16.
    
    ## Description
    
    These aren't needed or used anymore, so we can stop providing them.
    
    ## Testing
    
    <!-- Describe your testing strategy or note what tests are included -->
    
    ## Risks
    
    <!-- Note any risks associated with this change, or "None" if no risks
    -->
    
    ## Additional Notes
    
    <!-- Any other information that would be helpful for reviewers -->
    
    Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
    dd-octo-sts[bot] and brettlangdon authored Oct 17, 2025
    Configuration menu
    Copy the full SHA
    ddf29d2 View commit details
    Browse the repository at this point in the history
  2. fix(grpc): leaking spans when using gRPC future interface [backport 3…

    ….16] (#14900)
    
    Backport 75a8246 from #14875 to 3.16.
    
    We've tracked down some issues related to broken span hierarchy down to
    the way that the gRPC instrumentation deals with entering spans, which
    causes the grpc span to leak outside it's call when using the .future()
    interface. This PR changes the instrumentation to explicitly only enter
    the span when calling the continuations instead of just entering
    immediately.
    
    ## Description
    
    <!-- Provide an overview of the change and motivation for the change -->
    
    ## Testing
    
    I've added tests, but haven't run them for a while and working on
    getting it running locally. Will update if I run into any issues
    
    ## Risks
    
    <!-- Note any risks associated with this change, or "None" if no risks
    -->
    
    ## Additional Notes
    
    Co-authored-by: Sam Schlegel <sam.s@discordapp.com>
    
    Signed-off-by: Sam Schlegel <sam.s@discordapp.com>
    Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
    Co-authored-by: Sam Schlegel <sam.s@discordapp.com>
    Co-authored-by: Christophe Papazian <114495376+christophe-papazian@users.noreply.github.com>
    4 people authored Oct 17, 2025
    Configuration menu
    Copy the full SHA
    0b609cf View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2025

  1. fix(wrapt): do not use wrapt 2.x yet [backport 3.16] (#14964)

    Backport 492135a from #14955 to 3.16.
    
    ## Description
    
    <!-- Provide an overview of the change and motivation for the change -->
    
    We have a bug report that there are recursion errors with wrapt 2.x on
    our psycopg integration. I'd still like to study if we can recreate the
    error in a test but don't want this investigation to block this known
    issue.
    
    ## Testing
    
    <!-- Describe your testing strategy or note what tests are included -->
    
    ## Risks
    
    <!-- Note any risks associated with this change, or "None" if no risks
    -->
    
    ## Additional Notes
    
    <!-- Any other information that would be helpful for reviewers -->
    
    Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
    Co-authored-by: wantsui <wan.tsui@datadoghq.com>
    Co-authored-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
    Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
    4 people authored Oct 21, 2025
    Configuration menu
    Copy the full SHA
    7c062e5 View commit details
    Browse the repository at this point in the history
  2. ci: fix alpine sdist test [backport 3.16] (#14968)

    Backport e1b6efa from #14963 to 3.16.
    
    ## Description
    
    theacodes/cmarkgfm#84
    
    `cmarkgfm` released a new version which no longer properly installs.
    This explicitly installs a known working version.
    
    ## Testing
    
    <!-- Describe your testing strategy or note what tests are included -->
    
    ## Risks
    
    <!-- Note any risks associated with this change, or "None" if no risks
    -->
    
    ## Additional Notes
    
    <!-- Any other information that would be helpful for reviewers -->
    
    Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
    dd-octo-sts[bot] and brettlangdon authored Oct 21, 2025
    Configuration menu
    Copy the full SHA
    4c55a72 View commit details
    Browse the repository at this point in the history
  3. ci: pin wrapt<2 in typing checker [backport 3.16] (#14974)

    Backport 0b0f0d3 from #14971 to 3.16.
    
    ## Description
    
    ddapm-test-agent installs vcrpy which installs "wrapt" with no
    constraints. This meant we were still install wrapt 2.0 in our hatch
    lint environment causing us to type against wrapt 2 even though we
    updated pyproject.toml to be "wrapt>=1,<2".
    
    ## Testing
    
    <!-- Describe your testing strategy or note what tests are included -->
    
    ## Risks
    
    <!-- Note any risks associated with this change, or "None" if no risks
    -->
    
    ## Additional Notes
    
    <!-- Any other information that would be helpful for reviewers -->
    
    Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
    dd-octo-sts[bot] and brettlangdon authored Oct 21, 2025
    Configuration menu
    Copy the full SHA
    de9dbc1 View commit details
    Browse the repository at this point in the history
Loading