Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Handle term parent on update / create term#1221

Merged
danielbachhuber merged 4 commits intodevelopfrom
term-parent-update
May 19, 2015
Merged

Handle term parent on update / create term#1221
danielbachhuber merged 4 commits intodevelopfrom
term-parent-update

Conversation

@joehoyle
Copy link
Copy Markdown
Member

@joehoyle joehoyle commented May 8, 2015

Fixes #1204

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parent isn't present in the schema, so we don't need to worry about the taxonomy check.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is here to provide feedback to someone sending the parent and not realizing. I think we shouldn't proesume everyone is reading the schema

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #1223, the argument won't be included.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As #1223 hasn't been decided o nor included, I'm going to leave this in.

@danielbachhuber danielbachhuber added this to the 2.0 Beta 2 milestone May 8, 2015
danielbachhuber pushed a commit that referenced this pull request May 19, 2015
Handle term parent on update / create term
@danielbachhuber danielbachhuber merged commit 5cb3873 into develop May 19, 2015
@danielbachhuber danielbachhuber deleted the term-parent-update branch May 19, 2015 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support changing parent on hierarchical taxonomies.

2 participants