Connectors: Several strings are not translated #11514
Connectors: Several strings are not translated #11514manishdhorepatil-art wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ManishDhorepatil. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
left a comment
There was a problem hiding this comment.
I worked with @manishdhorepatil-art today at WordCamp Asia Contributor Day.
The GitHub Actions workflows are failing because there are changes being made to the files included from the built Gutenberg repository. Those template files will need to be updated over there.
However, it does not seem like this is the right solution. The translations are not available because they are not being localized properly and made available for wp-i18n. This seems to be due to the fact that there's no equivalent to wp_set_script_translations() for script modules. This will likely need updates to both gutenberg and wordpress-develop to resolve.
|
I'm going to close this out since a different approach entirely is necessary. |
I tested this issue again on the latest WordPress trunk and found that some strings in the Connectors screen are still not translated when switching to a non-English language.
issues Affected strings:
Other buttons like "Install" and "Cancel" are translated correctly.
Issue cause:
__()@wordpress/i18nChanges done :
__( 'string', 'text-domain' )import { __ } from '@wordpress/i18n';Patch: https://core.trac.wordpress.org/ticket/65015
Testing: