[Policy tests] Add suffix to agent and package policies to avoid collisions (#3118)

This PR adds a random suffix to the Agent policy and package policies
to avoid name collisions in policy tests, ensuring that each policy created
by each test defined different names.

Author: mrodm

internal/testrunner/runners/policy/policy.go

@@ -101,11 +101,12 @@ func expectedPathFor(testPath string) string {
 }
 
 type policyEntryFilter struct {
-	name            string
-	elementsEntries []policyEntryFilter
-	memberReplace   *policyEntryReplace
-	onlyIfEmpty     bool
-	ignoreValues    []any
+	name               string
+	elementsEntries    []policyEntryFilter
+	memberReplace      *policyEntryReplace
+	stringValueReplace *policyEntryReplace
+	onlyIfEmpty        bool
+	ignoreValues       []any
 }
 
 type policyEntryReplace struct {
@@ -125,6 +126,10 @@ var policyEntryFilters = []policyEntryFilter{
 		{name: "streams", elementsEntries: []policyEntryFilter{
 			{name: "id"},
 		}},
+		{name: "name", stringValueReplace: &policyEntryReplace{
+			regexp:  regexp.MustCompile(`^(.+)-[0-9]+$`),
+			replace: "$1",
+		}},
 	}},
 	{name: "secret_references", elementsEntries: []policyEntryFilter{
 		{name: "id"},
@@ -310,6 +315,17 @@ func cleanPolicyMap(policyMap common.MapStr, entries []policyEntryFilter) (commo
 					m[key] = e
 				}
 			}
+		case entry.stringValueReplace != nil:
+			vStr, ok := v.(string)
+			if !ok {
+				return nil, fmt.Errorf("expected string, found %T", v)
+			}
+			regexp := entry.stringValueReplace.regexp
+			replacement := entry.stringValueReplace.replace
+			if regexp.MatchString(vStr) {
+				value := regexp.ReplaceAllString(vStr, replacement)
+				policyMap.Put(entry.name, value)
+			}
 		default:
 			if entry.onlyIfEmpty && !isEmpty(v, entry.ignoreValues) {
 				continue

internal/testrunner/runners/policy/policy_test.go

@@ -83,6 +83,31 @@ namespaces: []
 `,
 			found: `
 namespaces: [foo]
+`,
+			equal: false,
+		},
+		{
+			title: "clean suffix in package policy name",
+			expected: `
+inputs:
+    - data_stream:
+        namespace: ep
+      meta:
+        package:
+            name: test_package
+      name: test-name
+      streams: []
+      type: test_package/logs
+      use_output: default
+`,
+			found: `
+inputs:
+    - data_stream:
+        namespace: ep
+      meta:
+        package:
+            name: test_package
+      name: test-name-12345
 `,
 			equal: false,
 		},
@@ -95,7 +120,7 @@ inputs:
       meta:
         package:
             name: sql_input
-      name: test-mysql-sql_input
+      name: test-mysql-sql_input-12345
       streams:
         - data_stream:
             dataset: sql_input.sql_query

internal/testrunner/runners/policy/tester.go

@@ -6,11 +6,13 @@ package policy
 
 import (
 	"context"
+	"fmt"
 	"path/filepath"
 	"strings"
 
 	"github.com/elastic/go-resource"
 
+	"github.com/elastic/elastic-package/internal/common"
 	"github.com/elastic/elastic-package/internal/kibana"
 	"github.com/elastic/elastic-package/internal/logger"
 	"github.com/elastic/elastic-package/internal/resources"
@@ -108,12 +110,13 @@ func (r *tester) runTest(ctx context.Context, manager *resources.Manager, testPa
 		return result.WithSkip(skip)
 	}
 
+	policyTestSuffix := common.CreateTestRunID()
 	policy := resources.FleetAgentPolicy{
-		Name:      testName,
+		Name:      fmt.Sprintf("%s-%s", testName, policyTestSuffix),
 		Namespace: "ep",
 		PackagePolicies: []resources.FleetPackagePolicy{
 			{
-				Name:           testName + "-" + r.testFolder.Package,
+				Name:           fmt.Sprintf("%s-%s-%s", testName, r.testFolder.Package, policyTestSuffix),
 				PackageRoot:    r.packageRoot,
 				DataStreamName: r.testFolder.DataStream,
 				InputName:      testConfig.Input,