Add some tests for EPR_PROXY_TO override in profile (#3224)

Author: mrodm

internal/configuration/locations/locations_internal_test.go

@@ -36,22 +36,18 @@ func Test_configurationDirError(t *testing.T) {
 	default:
 		env = "HOME"
 	}
-	homeEnv := os.Getenv(env)
-	os.Unsetenv(env)
+	t.Setenv(env, "")
 
 	_, err := configurationDir()
 	assert.Error(t, err)
-
-	os.Setenv(env, homeEnv)
 }
 
 func Test_configurationDirOverride(t *testing.T) {
 	expected := "/tmp/foobar"
-	os.Setenv(elasticPackageDataHome, expected)
+	t.Setenv(elasticPackageDataHome, expected)
 
 	actual, err := configurationDir()
 	assert.Nil(t, err)
 
 	assert.Equal(t, expected, actual)
-	os.Setenv(elasticPackageDataHome, "")
 }

internal/stack/resources.go

@@ -29,6 +29,9 @@ const (
 	// ComposeFile is the docker compose file.
 	ComposeFile = "docker-compose.yml"
 
+	// DockerfilePackageRegistryFile is the dockerfile for package-registry container.
+	DockerfilePackageRegistryFile = "Dockerfile.package-registry"
+
 	// ElasticsearchConfigFile is the elasticsearch config file.
 	ElasticsearchConfigFile = "elasticsearch.yml"
 
@@ -77,7 +80,7 @@ var (
 	staticSource   = resource.NewSourceFS(static).WithTemplateFuncs(templateFuncs)
 	stackResources = []resource.Resource{
 		&resource.File{
-			Path:    "Dockerfile.package-registry",
+			Path:    DockerfilePackageRegistryFile,
 			Content: staticSource.Template("_static/Dockerfile.package-registry.tmpl"),
 		},
 		&resource.File{

internal/stack/resources_test.go

@@ -24,7 +24,7 @@ func TestApplyResourcesWithCustomGeoipDir(t *testing.T) {
 	elasticPackagePath := t.TempDir()
 	profilesPath := filepath.Join(elasticPackagePath, "profiles")
 
-	os.Setenv("ELASTIC_PACKAGE_DATA_HOME", elasticPackagePath)
+	t.Setenv("ELASTIC_PACKAGE_DATA_HOME", elasticPackagePath)
 
 	// Create profile.
 	err := profile.CreateProfile(profile.Options{
@@ -70,6 +70,82 @@ func TestApplyResourcesWithCustomGeoipDir(t *testing.T) {
 	assert.Contains(t, volumes, expectedVolume)
 }
 
+func TestApplyResourcesWithDefaultPackageRegistryURL(t *testing.T) {
+	const profileName = "custom_package_registry"
+	const expectedEPR = "https://epr.elastic.co"
+
+	elasticPackagePath := t.TempDir()
+	profilesPath := filepath.Join(elasticPackagePath, "profiles")
+
+	t.Setenv("ELASTIC_PACKAGE_DATA_HOME", elasticPackagePath)
+
+	// Create profile.
+	err := profile.CreateProfile(profile.Options{
+		ProfilesDirPath: profilesPath,
+		Name:            profileName,
+	})
+	require.NoError(t, err)
+
+	p, err := profile.LoadProfile(profileName)
+	require.NoError(t, err)
+	t.Logf("Profile name: %s, path: %s", p.ProfileName, p.ProfilePath)
+
+	// Ensure that the profile has no specific configuration for EPR proxy.
+	v := p.Config(configElasticEPRProxyTo, "")
+	require.Equal(t, "", v)
+
+	// Now, apply resources and check that the variable has been used.
+	stackVersion := "8.6.1"
+	err = applyResources(p, stackVersion, stackVersion)
+	require.NoError(t, err)
+
+	d, err := os.ReadFile(p.Path(ProfileStackPath, DockerfilePackageRegistryFile))
+	require.NoError(t, err)
+
+	assert.Contains(t, string(d), fmt.Sprintf("ENV EPR_PROXY_TO=%s", expectedEPR))
+}
+
+func TestApplyResourcesWithCustomPackageRegistryURL(t *testing.T) {
+	const profileName = "custom_package_registry"
+	const expectedEPR = "http://localhost"
+
+	elasticPackagePath := t.TempDir()
+	profilesPath := filepath.Join(elasticPackagePath, "profiles")
+
+	t.Setenv("ELASTIC_PACKAGE_DATA_HOME", elasticPackagePath)
+
+	// Create profile.
+	err := profile.CreateProfile(profile.Options{
+		ProfilesDirPath: profilesPath,
+		Name:            profileName,
+	})
+	require.NoError(t, err)
+
+	// Write configuration to the profile.
+	configPath := filepath.Join(profilesPath, profileName, profile.PackageProfileConfigFile)
+	config := fmt.Sprintf("%s: %q", configElasticEPRProxyTo, expectedEPR)
+	err = os.WriteFile(configPath, []byte(config), 0644)
+	require.NoError(t, err)
+
+	p, err := profile.LoadProfile(profileName)
+	require.NoError(t, err)
+	t.Logf("Profile name: %s, path: %s", p.ProfileName, p.ProfilePath)
+
+	// Smoke test to check that we are actually loading the profile we want and it has the setting.
+	v := p.Config(configElasticEPRProxyTo, "")
+	require.Equal(t, expectedEPR, v)
+
+	// Now, apply resources and check that the variable has been used.
+	stackVersion := "8.6.1"
+	err = applyResources(p, stackVersion, stackVersion)
+	require.NoError(t, err)
+
+	d, err := os.ReadFile(p.Path(ProfileStackPath, DockerfilePackageRegistryFile))
+	require.NoError(t, err)
+
+	assert.Contains(t, string(d), fmt.Sprintf("ENV EPR_PROXY_TO=%s", expectedEPR))
+}
+
 func TestSemverLessThan(t *testing.T) {
 	b, err := semverLessThan("8.9.0", "8.10.0-SNAPSHOT")
 	require.NoError(t, err)