Ensure all errors are managed in parameters (#3008)

Author: mrodm

cmd/edit.go

@@ -59,12 +59,15 @@ func editDashboardsCmd(cmd *cobra.Command, args []string) error {
 	common.TrimStringSlice(dashboardIDs)
 
 	var opts []kibana.ClientOption
-	tlsSkipVerify, _ := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
+	tlsSkipVerify, err := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
+	if err != nil {
+		return cobraext.FlagParsingError(err, cobraext.TLSSkipVerifyFlagName)
+	}
 	if tlsSkipVerify {
 		opts = append(opts, kibana.TLSSkipVerify())
 	}
 
-	allowSnapshot, _ := cmd.Flags().GetBool(cobraext.AllowSnapshotFlagName)
+	allowSnapshot, err := cmd.Flags().GetBool(cobraext.AllowSnapshotFlagName)
 	if err != nil {
 		return cobraext.FlagParsingError(err, cobraext.AllowSnapshotFlagName)
 	}

cmd/export_dashboards.go

@@ -34,7 +34,10 @@ func exportDashboardsCmd(cmd *cobra.Command, args []string) error {
 	common.TrimStringSlice(dashboardIDs)
 
 	var opts []kibana.ClientOption
-	tlsSkipVerify, _ := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
+	tlsSkipVerify, err := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
+	if err != nil {
+		return cobraext.FlagParsingError(err, cobraext.TLSSkipVerifyFlagName)
+	}
 	if tlsSkipVerify {
 		opts = append(opts, kibana.TLSSkipVerify())
 	}

cmd/export_ingest_pipelines.go

@@ -40,7 +40,10 @@ func exportIngestPipelinesCmd(cmd *cobra.Command, args []string) error {
 	common.TrimStringSlice(pipelineIDs)
 
 	var opts []elasticsearch.ClientOption
-	tlsSkipVerify, _ := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
+	tlsSkipVerify, err := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
+	if err != nil {
+		return cobraext.FlagParsingError(err, cobraext.TLSSkipVerifyFlagName)
+	}
 	if tlsSkipVerify {
 		opts = append(opts, elasticsearch.OptionWithSkipTLSVerify())
 	}

cmd/install.go

@@ -60,7 +60,10 @@ func installCommandAction(cmd *cobra.Command, _ []string) error {
 	}
 
 	var opts []kibana.ClientOption
-	tlsSkipVerify, _ := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
+	tlsSkipVerify, err := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
+	if err != nil {
+		return cobraext.FlagParsingError(err, cobraext.TLSSkipVerifyFlagName)
+	}
 	if tlsSkipVerify {
 		opts = append(opts, kibana.TLSSkipVerify())
 	}