[bug] Refactor Storybook main config for ESM compatibility.#7957
Closed
Han5991 wants to merge 2 commits intomantinedev:masterfrom
Closed
[bug] Refactor Storybook main config for ESM compatibility.#7957Han5991 wants to merge 2 commits intomantinedev:masterfrom
Han5991 wants to merge 2 commits intomantinedev:masterfrom
Conversation
Updated imports and path resolution to align with ES module standards, replacing CommonJS-specific methods. This ensures compatibility with modern JavaScript tooling while maintaining functionality.
3b32ba1 to
afbe48d
Compare
Contributor
Author
|
Since Node.js 20 EOL is approaching, would it be worth upgrading to Node.js 24 LTS as well? |
Member
|
Currently, Mantine uses Node.js 22.11, the version is available in |
Contributor
Author
Got it, thanks for pointing that out! Node.js 22.11 is indeed a solid choice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the Storybook configuration to ensure compatibility with ECMAScript Modules (ESM). The changes include:
Changes Made
Technical Details
Background
Testing
Future Compatibility
According to https://nodejs.org/en/about/previous-releases, Node.js 20 will reach End-of-Life soon, making these ESM improvements increasingly important for modern JavaScript environments.
Related Issue
Fixes storybookjs/storybook#30115
This ensures Storybook configuration works correctly in modern JavaScript environments while maintaining compatibility with existing tooling.