Skip to content

Commit d737978

Browse files
authored
fix: fix release-please PR title pattern and permissions (#1978)
## Summary - Add `group-pull-request-title-pattern` with `${version}` so release-please can match the merged PR and create the GitHub release. The default group title is `chore: release main` which lacks the version, preventing release creation on merge. - Add `issues: write` permission (incorporates #1975) - Remove `separate-pull-requests: false` (already the default) - Remove redundant `extra-files` (maven type auto-discovers pom.xml) Supersedes #1975 ## Test plan - [ ] CI passes - [ ] After merge, release-please creates PR with title like `chore(main): release 1.5.1` - [ ] Merging that PR creates v1.5.1 tag and GitHub release Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
1 parent 89052fc commit d737978

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
{
22
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
3-
"separate-pull-requests": false,
3+
"group-pull-request-title-pattern": "chore${scope}: release${component} ${version}",
44
"pull-request-footer": "> [!IMPORTANT]\n> Close and reopen this PR to trigger CI checks.",
55
"packages": {
66
".": {
7-
"release-type": "maven",
8-
"extra-files": ["integration-tests/it-spring-boot-smoke-test/pom.xml"]
7+
"release-type": "maven"
98
}
109
}
1110
}

‎.github/workflows/release-please.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88

99
permissions:
1010
contents: write
11+
issues: write
1112
pull-requests: write
1213

1314
jobs:

0 commit comments

Comments
 (0)