[javadoc] Rename parameter of ProxyOutputStream.write(int)#740
Merged
garydgregory merged 1 commit intoapache:masterfrom Apr 15, 2025
Merged
[javadoc] Rename parameter of ProxyOutputStream.write(int)#740garydgregory merged 1 commit intoapache:masterfrom
ProxyOutputStream.write(int)#740garydgregory merged 1 commit intoapache:masterfrom
Conversation
asfgit
pushed a commit
that referenced
this pull request
Apr 15, 2025
Member
|
@jglick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very trivial, but I noticed that the parameter of this method was named
idx, which would usually be construed as an abbreviation forindex, which in this context would be presumed to be an index into abyte[]. But that is not what it is; it is a byte (typed asintfor what I suppose are historical reasons). The supertypesOutputStreamandFilterOutputStreamname the parameterb, which seems more intuitive.