Validation timeout is not propagated properly if isUseJdbc4Validation=true

[anmalysh-yb]

This hardcodes timeout to 1 second:

https://github.com/brettwooldridge/HikariCP/blob/dev/src/main/java/com/zaxxer/hikari/pool/PoolBase.java#L478

And ignores validationTimeout set by a user.

This makes connection validation to fail in case DB is located far enough from the application and has high RTT.

[DimaVilda]

@brettwooldridge could be also a good first issue for me. I think, can I be assigned pls ?
https://github.com/brettwooldridge/HikariCP/blob/dev/src/main/java/com/zaxxer/hikari/pool/PoolBase.java#L478
you just missed 'validationTimeout' here.

@anmalysh-yb in meanwhile you can alternatively use 'connectionTestQuery ' property ( ie 'SELECT 1') to validate your connection. In that case
https://github.com/brettwooldridge/HikariCP/blob/dev/src/main/java/com/zaxxer/hikari/pool/PoolBase.java#L478
won't be used.

[brettwooldridge]

@DimaVilda Sorry, I made the fix before seeing your comment.

connection.isValid(Math.max(1, (int) MILLISECONDS.toSeconds(validationTimeout)));

[brettwooldridge]

Fix committed.

[DimaVilda]

@DimaVilda Sorry, I made the fix before seeing your comment.

connection.isValid(Math.max(1, (int) MILLISECONDS.toSeconds(validationTimeout)));

nooooooooo