fix(schema): add missing settings type#6070
Merged
Conversation
The JSON schema is missing a type for the `settings` key. To reproduce this, create a `mise.toml` with a `[settings]` key and lint the file using the JSON schema. ```sh printf '[settings]\n' >mise.toml uvx --from "tombi>=0.5,<0.6" tombi lint --no-cache mise.toml ``` ```log Error: invalid json pointer: #/$defs/settings, schema_uri: https://mise.jdx.dev/schema/mise.json ``` This commit will add `"type": "object"` to the `settings` key in the JSON schema. Signed-off-by: Brendon Smith <bws@bws.bio>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing type declaration in the JSON schema for the settings key. The schema was missing the "type": "object" property, which caused validation errors when linting TOML files containing a [settings] section.
- Adds missing
"type": "object"declaration to thesettingsschema definition
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
jdx
pushed a commit
that referenced
this pull request
Aug 20, 2025
### 🚀 Features - **(http)** auto-clean OS/arch suffixes from binary names by [@jdx](https://github.com/jdx) in [#6077](#6077) - **(install)** add --dry-run flag to show what would be installed by [@jdx](https://github.com/jdx) in [#6078](#6078) ### 🐛 Bug Fixes - **(python)** patching sysconfig data fails for RC versions by [@roele](https://github.com/roele) in [#6069](#6069) - **(schema)** add missing `settings` type by [@br3ndonland](https://github.com/br3ndonland) in [#6070](#6070) ### Chore - add liblzma-dev for e2e tests to avoid python-build warning by [@jdx](https://github.com/jdx) in [#6066](#6066)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The JSON schema is missing a type for the
settingskey.mise/schema/mise.json
Line 225 in 57c2b1c
To reproduce this, create a
mise.tomlwith a[settings]key and lint the file using the JSON schema.Changes
This PR will add
"type": "object"to thesettingskey in the JSON schema.Related