JDK 8 compatibility fix for vector datatype handling#2750
Merged
muskan124947 merged 1 commit intomainfrom Aug 28, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2750 +/- ##
============================================
+ Coverage 51.51% 51.53% +0.01%
+ Complexity 4081 4078 -3
============================================
Files 149 149
Lines 34268 34268
Branches 5725 5725
============================================
+ Hits 17654 17659 +5
+ Misses 14125 14119 -6
- Partials 2489 2490 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ananya2
approved these changes
Aug 27, 2025
David-Engel
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After adding Vector datatype support #2634, we observed failures on JDK 8 due to a NoSuchMethodError when invoking ByteBuffer.position(int).
Root Cause
Directly calling ByteBuffer.position(int) caused incompatibility and resulted in NoSuchMethodError on JDK 8.
Fix
Cast the ByteBuffer instance to Buffer before calling position().
This ensures consistent behavior across JDK 8 and newer versions.
Testing