Skip to content

Use correct GORELEASE tags for all the gorelease actions.#1158

Merged
bogdandrutu merged 1 commit intoopen-telemetry:mainfrom
bogdandrutu:fix-github-tag
Sep 2, 2025
Merged

Use correct GORELEASE tags for all the gorelease actions.#1158
bogdandrutu merged 1 commit intoopen-telemetry:mainfrom
bogdandrutu:fix-github-tag

Conversation

@bogdandrutu
Copy link
Copy Markdown
Member

@bogdandrutu bogdandrutu commented Sep 2, 2025

Skipping changelog since this is not an external change. The problem is that if we have a failure with a previously added tag, we cannot re-run that action because it will read the latest tag added instead of the one that triggered the action.

Here is how to reproduce the problem:

  1. Add a tag T1 -> action fails (for some reasons).
  2. Add a tag T2 (nightly for example) and triggers a new build;
  3. If you try to re-run the action triggered by T1 will read T2 as the current tag

To explain more what happened in 134 release:

  1. The upgrade PR for 133-134 landed at 5:24PM - PST
  2. The nightly tag v0.134.0-nightly.202508310234 landed at 7:34PM - PST on the upgrade PR
  3. The release tag v0.134.0 landed at 9:22PM - PST on the upgrade PR (there was a failure to add to the right commit, but that will not affect this since release did not happened on that PR and GH actions fails with the right tag at right commit)

The release Action Item (on windows) trigger by the tag v0.134.0 reads the nightly tag instead of the release v0.134.0 from that commit.

@bogdandrutu bogdandrutu requested a review from a team as a code owner September 2, 2025 17:31
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu
Copy link
Copy Markdown
Member Author

The failure test does not seem to be related to this change.

@bogdandrutu bogdandrutu added this pull request to the merge queue Sep 2, 2025
Merged via the queue into open-telemetry:main with commit 23173dd Sep 2, 2025
127 of 131 checks passed
@bogdandrutu bogdandrutu deleted the fix-github-tag branch September 2, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants