Use correct GORELEASE tags for all the gorelease actions.#1158
Merged
bogdandrutu merged 1 commit intoopen-telemetry:mainfrom Sep 2, 2025
Merged
Use correct GORELEASE tags for all the gorelease actions.#1158bogdandrutu merged 1 commit intoopen-telemetry:mainfrom
bogdandrutu merged 1 commit intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
a84aa30 to
b6f86a2
Compare
pjanotti
approved these changes
Sep 2, 2025
Member
Author
|
The failure test does not seem to be related to this change. |
atoulme
approved these changes
Sep 2, 2025
Merged
via the queue into
open-telemetry:main
with commit Sep 2, 2025
23173dd
127 of 131 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping changelog since this is not an external change. The problem is that if we have a failure with a previously added tag, we cannot re-run that action because it will read the latest tag added instead of the one that triggered the action.
Here is how to reproduce the problem:
To explain more what happened in 134 release:
v0.134.0-nightly.202508310234landed at 7:34PM - PST on the upgrade PRv0.134.0landed at 9:22PM - PST on the upgrade PR (there was a failure to add to the right commit, but that will not affect this since release did not happened on that PR and GH actions fails with the right tag at right commit)The release Action Item (on windows) trigger by the tag
v0.134.0reads the nightly tag instead of the releasev0.134.0from that commit.