fix micrometer bridge auto configuration annotation#13083

zeitlinger · 2025-01-22T13:05:29Z

Fixes #12719 - hopefully

trask

do you think a test could be added for this?

zeitlinger · 2025-01-23T11:37:11Z

do you think a test could be added for this?

yes - I even found the test that I broke with this PR.

laurit · 2025-02-06T17:14:35Z

+testing {
+  suites {
+    val testPrometheus by registering(JvmTestSuite::class) {
+      dependencies {
+        runtimeOnly("io.micrometer:micrometer-registry-prometheus:1.14.3")
+      }
+    }
+  }
+}


since there are no source for this suite it won't run any tests as far as I can tell

OK - I had to test this by adding id("com.adarshr.test-logger") version "4.0.0" to see that noting gets executed...

used the setup for stable semconv now

…gaining that much

zeitlinger · 2025-02-07T18:33:02Z

Exception

    java.lang.IllegalStateException: Error processing condition on org.springframework.boot.actuate.autoconfigure.metrics.export.prometheus.PrometheusSimpleclientMetricsExportAutoConfiguration.simpleclientPrometheusMeterRegistry	
        at org.springframework.boot.autoconfigure.condition.SpringBootCondition.matches(SpringBootCondition.java:60)	
        at org.springframework.context.annotation.ConditionEvaluator.shouldSkip(ConditionEvaluator.java:99)	
        at org.springframework.context.annotation.ConfigurationClassBeanDefinitionReader.loadBeanDefinitionsForBeanMethod(ConfigurationClassBeanDefinitionReader.java:184)	
        at org.springframework.context.annotation.ConfigurationClassBeanDefinitionReader.loadBeanDefinitionsForConfigurationClass(ConfigurationClassBeanDefinitionReader.java:145)	
        at org.springframework.context.annotation.ConfigurationClassBeanDefinitionReader.loadBeanDefinitions(ConfigurationClassBeanDefinitionReader.java:121)	
        at org.springframework.context.annotation.ConfigurationClassPostProcessor.processConfigBeanDefinitions(ConfigurationClassPostProcessor.java:430)	
        at org.springframework.context.annotation.ConfigurationClassPostProcessor.postProcessBeanDefinitionRegistry(ConfigurationClassPostProcessor.java:290)	
        at org.springframework.context.support.PostProcessorRegistrationDelegate.invokeBeanDefinitionRegistryPostProcessors(PostProcessorRegistrationDelegate.java:349)	
        at org.springframework.context.support.PostProcessorRegistrationDelegate.invokeBeanFactoryPostProcessors(PostProcessorRegistrationDelegate.java:118)	
        at org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:791)	
        at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:609)	
        at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:752)	
        at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:439)	
        at org.springframework.boot.SpringApplication.run(SpringApplication.java:318)	
        at io.opentelemetry.javaagent.instrumentation.spring.actuator.v2_0.ActuatorTest.shouldInjectOtelMeterRegistry(ActuatorTest.java:35)	
        Caused by:	
        java.lang.IllegalStateException: Failed to introspect Class [org.springframework.boot.actuate.autoconfigure.metrics.export.prometheus.PrometheusSimpleclientMetricsExportAutoConfiguration] from ClassLoader [jdk.internal.loader.ClassLoaders$AppClassLoader@76ed5528]	
            at org.springframework.util.ReflectionUtils.getDeclaredMethods(ReflectionUtils.java:483)	
            at org.springframework.util.ReflectionUtils.doWithMethods(ReflectionUtils.java:360)	
            at org.springframework.util.ReflectionUtils.getUniqueDeclaredMethods(ReflectionUtils.java:417)	
            at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.lambda$getTypeForFactoryMethod$1(AbstractAutowireCapableBeanFactory.java:751)	
            at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)	
            at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.getTypeForFactoryMethod(AbstractAutowireCapableBeanFactory.java:750)	
            at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.determineTargetType(AbstractAutowireCapableBeanFactory.java:683)	
            at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.predictBeanType(AbstractAutowireCapableBeanFactory.java:654)	
            at org.springframework.beans.factory.support.AbstractBeanFactory.isFactoryBean(AbstractBeanFactory.java:1683)	
            at org.springframework.beans.factory.support.DefaultListableBeanFactory.doGetBeanNamesForType(DefaultListableBeanFactory.java:592)	
            at org.springframework.beans.factory.support.DefaultListableBeanFactory.getBeanNamesForType(DefaultListableBeanFactory.java:564)	
            at org.springframework.boot.autoconfigure.condition.OnBeanCondition.collectBeanDefinitionsForType(OnBeanCondition.java:332)	
            at org.springframework.boot.autoconfigure.condition.OnBeanCondition.getBeanDefinitionsForType(OnBeanCondition.java:324)	
            at org.springframework.boot.autoconfigure.condition.OnBeanCondition.getBeanDefinitionsForType(OnBeanCondition.java:314)	
            at org.springframework.boot.autoconfigure.condition.OnBeanCondition.getMatchingBeans(OnBeanCondition.java:213)	
            at org.springframework.boot.autoconfigure.condition.OnBeanCondition.evaluateConditionalOnMissingBean(OnBeanCondition.java:196)	
            at org.springframework.boot.autoconfigure.condition.OnBeanCondition.getMatchOutcome(OnBeanCondition.java:143)	
            at org.springframework.boot.autoconfigure.condition.SpringBootCondition.matches(SpringBootCondition.java:47)	
            ... 14 more	
            Caused by:	
            java.lang.NoClassDefFoundError: io/prometheus/client/exemplars/tracer/common/SpanContextSupplier	
                at java.base/java.lang.Class.getDeclaredMethods0(Native Method)	
                at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3578)	
                at java.base/java.lang.Class.getDeclaredMethods(Class.java:2676)	
                at org.springframework.util.ReflectionUtils.getDeclaredMethods(ReflectionUtils.java:465)	
                ... 31 more	
                Caused by:	
                java.lang.ClassNotFoundException: io.prometheus.client.exemplars.tracer.common.SpanContextSupplier	
                    at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)	
                    at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)	
                    at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)	
                    ... 35 more

zeitlinger · 2025-02-10T09:59:37Z

I can't reproduce the error locally with ./gradlew :instrumentation:spring:spring-boot-actuator-autoconfigure-2.0:javaagent:test -PtestIndy=true

@laurit can you help?

laurit · 2025-02-10T13:38:02Z

I can't reproduce the error locally with ./gradlew :instrumentation:spring:spring-boot-actuator-autoconfigure-2.0:javaagent:test -PtestIndy=true

@laurit can you help?

For met it repros fine. I think the problem is in runtimeOnly("io.micrometer:micrometer-registry-prometheus:1.0.1") which means that this dependency along with its transitive dependencies is bundled inside the agent. When using indy we prefer classes from the agent over the application classes so muzzle checks fail because the micrometer version inside the agent doesn't have the required method.

laurit · 2025-02-10T13:38:36Z

  }
+
+  @Bean
+  static BeanPostProcessor postProcessCompositeMeterRegistry() {


do we have a convention of making these methods public?

the other bean post processor is also static:

opentelemetry-java-instrumentation/instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/jdbc/JdbcInstrumentationAutoConfiguration.java

Line 34 in 428aa28

static DataSourcePostProcessor dataSourcePostProcessor(

zeitlinger · 2025-02-10T14:59:30Z

I can't reproduce the error locally with ./gradlew :instrumentation:spring:spring-boot-actuator-autoconfigure-2.0:javaagent:test -PtestIndy=true
@laurit can you help?

For met it repros fine. I think the problem is in runtimeOnly("io.micrometer:micrometer-registry-prometheus:1.0.1") which means that this dependency along with its transitive dependencies is bundled inside the agent. When using indy we prefer classes from the agent over the application classes so muzzle checks fail because the micrometer version inside the agent doesn't have the required method.

thanks - I'll try with testLibrary

zeitlinger · 2025-02-10T16:21:29Z

I can't reproduce the error locally with ./gradlew :instrumentation:spring:spring-boot-actuator-autoconfigure-2.0:javaagent:test -PtestIndy=true
@laurit can you help?

For met it repros fine. I think the problem is in runtimeOnly("io.micrometer:micrometer-registry-prometheus:1.0.1") which means that this dependency along with its transitive dependencies is bundled inside the agent. When using indy we prefer classes from the agent over the application classes so muzzle checks fail because the micrometer version inside the agent doesn't have the required method.

thanks - I'll try with testLibrary

apparently that worked

@laurit I'm hoping that this also makes sense 😄

…javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/actuator/v2_0/OpenTelemetryMeterRegistryAutoConfiguration.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

zeitlinger requested a review from a team as a code owner January 22, 2025 13:05

zeitlinger changed the title ~~fix annotation~~ fix micrometer bridge auto configuration annotation Jan 22, 2025

trask reviewed Jan 22, 2025

View reviewed changes

zeitlinger self-assigned this Jan 23, 2025

zeitlinger force-pushed the micrometer-bridge-auto-config branch from a888249 to b9a2ab1 Compare January 27, 2025 13:43

trask reviewed Jan 27, 2025

View reviewed changes

Comment thread instrumentation/spring/spring-boot-actuator-autoconfigure-2.0/javaagent/build.gradle.kts Outdated

trask reviewed Jan 30, 2025

View reviewed changes

Comment thread ...aagent/instrumentation/spring/actuator/v2_0/OpenTelemetryMeterRegistryAutoConfiguration.java Outdated

zeitlinger added 7 commits February 6, 2025 13:52

fix annotation

293532b

fix annotation

b16bd81

fix annotation

ebb1ec1

fix annotation

d9dd0c0

fix annotation

e1da70e

improve test

a5b122b

sort the otel registry last explicitly

84abdcc

zeitlinger force-pushed the micrometer-bridge-auto-config branch from 0f347b6 to 84abdcc Compare February 6, 2025 14:05

laurit reviewed Feb 6, 2025

View reviewed changes

Comment thread .../test/java/io/opentelemetry/javaagent/instrumentation/spring/actuator/v2_0/ActuatorTest.java Outdated

laurit reviewed Feb 6, 2025

View reviewed changes

Comment thread .../test/java/io/opentelemetry/javaagent/instrumentation/spring/actuator/v2_0/ActuatorTest.java Outdated

zeitlinger added 6 commits February 7, 2025 14:22

fix dependency

e0e55bf

test order

ad052db

fix test

0061864

format

57e3ef9

running in latest dep doesn't work

5d67753

including prometheus conditionally doesn't seem to work - and it not …

3c5d708

…gaining that much

exclude auto config

01acb0d

laurit reviewed Feb 10, 2025

View reviewed changes

use testLibrary

b9ae5d1

laurit approved these changes Feb 11, 2025

View reviewed changes

trask reviewed Feb 11, 2025

View reviewed changes

Comment thread ...aagent/instrumentation/spring/actuator/v2_0/OpenTelemetryMeterRegistryAutoConfiguration.java Outdated

trask added this to the v2.13.0 milestone Feb 12, 2025

Update instrumentation/spring/spring-boot-actuator-autoconfigure-2.0/…

c24dcb2

…javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/actuator/v2_0/OpenTelemetryMeterRegistryAutoConfiguration.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

trask merged commit 15358d6 into open-telemetry:main Feb 12, 2025

zeitlinger deleted the micrometer-bridge-auto-config branch February 12, 2025 14:47

Conversation

zeitlinger commented Jan 22, 2025

Uh oh!

trask left a comment

Choose a reason for hiding this comment

Uh oh!

zeitlinger commented Jan 23, 2025

Uh oh!

Uh oh!

Uh oh!

laurit Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

zeitlinger Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zeitlinger commented Feb 7, 2025

Uh oh!

zeitlinger commented Feb 10, 2025

Uh oh!

laurit commented Feb 10, 2025

Uh oh!

laurit Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

zeitlinger Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

zeitlinger commented Feb 10, 2025

Uh oh!

zeitlinger commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zeitlinger commented Feb 10, 2025 •

edited

Loading