Merged
Conversation
Better late than never 😄
|
Great! But it would be nice to know why major, i.e. what are the breaking changes. |
awaterma
requested changes
Mar 23, 2020
Member
awaterma
left a comment
awaterma
left a comment
There was a problem hiding this comment.
Perhaps breakdown the changelog into "Major" and "Minor" sections for a version change.
Comment on lines
+7
to
+12
| - SameSite cookie support | ||
| - Cookie prefix support | ||
| - Support for promises | ||
| - Use ESLint and Prettier to apply consistent, modern formatting | ||
| - '.local' support | ||
| - Numerous bug fixes! |
Member
There was a problem hiding this comment.
Suggested change
| - SameSite cookie support | |
| - Cookie prefix support | |
| - Support for promises | |
| - Use ESLint and Prettier to apply consistent, modern formatting | |
| - '.local' support | |
| - Numerous bug fixes! | |
| ### Minor Changes | |
| - SameSite cookie support | |
| - Cookie prefix support | |
| - '.local' support | |
| - Numerous bug fixes! |
Member
|
@ShivanKaul -- let me know what you think; perhaps there's an even better way to setup our changelog. I wonder if we should also consider adding something like this as a Githook? |
awaterma
approved these changes
Mar 27, 2020
Member
awaterma
left a comment
awaterma
left a comment
There was a problem hiding this comment.
Looks great! Thank you for working on this @ShivanKaul!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better late than never 😄